feat: add error helper that does not read the response body #2964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quartzmo
reviewed
Jan 16, 2025
codyoss
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
codyoss
approved these changes
Jan 16, 2025
|
Thanks for the detailed report and contribution! |
|
@codyoss is there anything I can do re: the kokoro failures? It's not clear what the failure actually was based on the output I see. |
codyoss
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
codyoss
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
codyoss
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
codyoss
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
🤖 I have created a release *beep* *boop* --- ## [0.218.0](https://github.com/googleapis/google-api-go-client/compare/v0.217.0...v0.218.0) (2025-01-22) ### Features * Add error helper that does not read the response body ([#2964](https://github.com/googleapis/google-api-go-client/issues/2964)) ([9e749c4](https://github.com/googleapis/google-api-go-client/commit/9e749c4155022ced228d0989315f21b40b43af5c)) * **all:** Auto-regenerate discovery clients ([#2963](https://github.com/googleapis/google-api-go-client/issues/2963)) ([0bf19b3](https://github.com/googleapis/google-api-go-client/commit/0bf19b3736d5fc9b329e2fc73f7b45c79911373f)) * **all:** Auto-regenerate discovery clients ([#2967](https://github.com/googleapis/google-api-go-client/issues/2967)) ([a978c49](https://github.com/googleapis/google-api-go-client/commit/a978c49382816b1011c2f5eaeaee5e0ff7741f94)) * **all:** Auto-regenerate discovery clients ([#2969](https://github.com/googleapis/google-api-go-client/issues/2969)) ([a8aed4d](https://github.com/googleapis/google-api-go-client/commit/a8aed4dd688bcbc6e44b43211c58e5e09bb772e5)) * **all:** Auto-regenerate discovery clients ([#2970](https://github.com/googleapis/google-api-go-client/issues/2970)) ([607d371](https://github.com/googleapis/google-api-go-client/commit/607d371e04db7b53fb6d6327bb4ac770dac7d772)) * **all:** Auto-regenerate discovery clients ([#2972](https://github.com/googleapis/google-api-go-client/issues/2972)) ([0f4ee9d](https://github.com/googleapis/google-api-go-client/commit/0f4ee9d9b0f08d935da8bc5c8169e24b462307a3)) * **all:** Auto-regenerate discovery clients ([#2973](https://github.com/googleapis/google-api-go-client/issues/2973)) ([e143e5c](https://github.com/googleapis/google-api-go-client/commit/e143e5cadc749d877a27ba41b5b954fca3195776)) * **all:** Auto-regenerate discovery clients ([#2974](https://github.com/googleapis/google-api-go-client/issues/2974)) ([0d0bcdf](https://github.com/googleapis/google-api-go-client/commit/0d0bcdffc9017f5647b78b1405940c330578b3a1)) ### Bug Fixes * **internal/gensupport:** Close resp body only on discarding resp (resumableupload) ([#2966](https://github.com/googleapis/google-api-go-client/issues/2966)) ([840d496](https://github.com/googleapis/google-api-go-client/commit/840d49666b8c5e8ca1c07880cb6be2f0b78fbd6d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
CheckResponseWithBodyvariant to allow returning*googleapi.Errordetails for responses where the body may have already been read.Fixes googleapis/google-cloud-go#11458 (Part 1 of 2).