-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asp Mvc Core support #1109
Asp Mvc Core support #1109
Conversation
@buzallen Thanks for this PR. |
Thanks. Glad to know something is coming. |
Apologies that we've dropped the ball on this. I can give it a first pass today, but I suspect we'll need Chris's input too (and he's out today). Auth in general is still a bit up in the air, but I think we really do need this package. |
(One thing we'll need to consider is whether to target ASP.NET Core 1.x, 2.x or both - I'll have to do some testing to check what happens.) |
Right, I've now knocked together a little test app, and the good news is that it works, pretty much following the regular MVC instructions. In terms of the code itself, assuming we're happy to deviate from the design of the existing package:
In short: I'm really grateful that you've got this working, and it's a great first step. I don't want to merge it in yet though, and I definitely want to consult with Chris about his thoughts. I'd also like to spend some time looking at what other auth providers do - if there's a convention we can follow to simplify things, we really should do so. Now that it's on our radar again, I'll push to keep some momentum. If you see me dropping the ball again, please holler. |
Might we be better to use the Google authentication flow built in to ASP.NET Core, rather than using our 'custom' flow? I have a test app (in ASP.NET Core 2) that uses the standard I have not, however, ever written a "real" ASP.NET Core application that includes authentication, so it's quite likely I've missed or misunderstood something. If this is the case, I'm very happy to be corrected. |
That sounds infinitely better, yes :) I haven't looked at the auth flow in ASP.NET Core yet. Let's look at that code together in person. |
#1163 is the beginning of an implementation using the OpenIdConnect flow built into ASP.NET Core; which is the approach I'd prefer. |
Hey folks. Is this still in progress? As it stands right now I'm really struggling to get even the most basic auth going in a .NET Core ASPNET project. @chrisdunelm you mention getting it working with the official |
I can confirm that this works. I prefer the approach of using OpenIdConnect, but because of reasons, it turned out that I had to use this implementation. It was quite the struggle to get everything to work, but I managed. |
Closing, as superseded by #1163. |
Notes on the PR -
Thanks,
Brian