New submodules: upgrade before 2024-03-01 to avoid ambiguous import errors with google.golang.org/genproto #1015

quartzmo · 2023-05-26T15:17:22Z

TL;DR

Upgrade to a version of google.golang.org/genproto at or above version v0.0.0-20230526161137-0005af68ea54 with the following command:

go get google.golang.org/genproto@latest
go mod tidy

Doing this before the 9-month deadline of 2024-03-01 will avoid "ambiguous import" errors.

Background

Many of the packages in the google.golang.org/genproto module represent API surfaces belonging to Google Cloud. Since approximately the v0.0.0-20220921223823-23cae91e6737 release of google.golang.org/genproto, a change in #901 introduced dependencies on virtually every submodule in cloud.google.com/go. This change moved type definitions for Google Cloud client libraries to cloud.google.com/go, greatly improving usability of the latter. To maintain compatibility with existing code, aliases were introduced into google.golang.org/genproto that pointed to the new sources of truth in cloud.google.com/go. This added the dependencies on cloud modules.

Even though most packages in google.golang.org/genproto are Google Cloud, a few packages provide simple “common” types used in projects unrelated to Google Cloud. For users of the simpler packages, this commingled existence resulted in a large number of extra cloud modules appearing in the dependency graph. This can trigger alarms in automatic dependency checks, false positives in vulnerability checks, and adds constraints to minimum version selection when resolving acceptable versions of other dependencies.

New submodules in this repo

To improve usability for consumers that do not depend on Google Cloud modules, packages providing widely used "common" types will be published as submodules. The following packages do not depend on cloud types and are now isolated in new non-cloud submodules:

google.golang.org/genproto/googleapis/api (Note: this does not include 4 subpackages referencing cloud types, listed below)
google.golang.org/genproto/googleapis/bytestream
google.golang.org/genproto/googleapis/rpc

The following subpackages of google.golang.org/genproto/googleapis/api reference cloud types and are now isolated from the api package as new cloud submodules:

google.golang.org/genproto/googleapis/api/apikeys
google.golang.org/genproto/googleapis/api/servicecontrol
google.golang.org/genproto/googleapis/api/servicemanagement
google.golang.org/genproto/googleapis/api/serviceusage

To ease migration, these submodules initially have a “back-ref” dependency on the google.golang.org/genproto parent. After a 9-month period, this "back-ref" dependency will be removed, making it possible to once again depend on the simpler packages of this project without adding cloud modules to the dependency graph.

Avoiding ambiguous imports for submodules

The root package docs for google.golang.org/genproto state:

IMPORTANT This repository is currently experimental. The structure of the contained packages is subject to change. Please see the original source repositories (listed below) to find out the status of each protocol buffer's associated service.

In addition to this warning, the pseudo version numbering of the module:

Signals that the module is still in development and unstable. This release carries no backward compatibility or stability guarantees.

However, despite these warnings, we know that critical infrastructure depends on many of the packages in google.golang.org/genproto. To avoid "ambiguous import" errors for consumers, we are adding a “back-ref” dependency on the google.golang.org/genproto parent to each new submodule for 9 months to allow a seamless transition.

After the 9-month deadline of 2024-03-01 has passed, the “back-ref” dependency on the google.golang.org/genproto parent will be removed from each new submodule. Client code still using a version of the google.golang.org/genproto parent earlier than v0.0.0-20230525234044-86246a831fb4 may then encounter "ambiguous import" errors when importing packages that have been moved to submodules. Those errors can be resolved by updating to a version at or above version v0.0.0-20230526161137-0005af68ea54 with the following command:

go get google.golang.org/genproto@latest
go mod tidy

References

The text was updated successfully, but these errors were encountered:

This is to avoid issues caused by googleapis/go-genproto#1015 Signed-off-by: Alex Boten <[email protected]>

* [chore] updating google.golang.org/genproto This is to avoid issues caused by googleapis/go-genproto#1015 Signed-off-by: Alex Boten <[email protected]> * update example Signed-off-by: Alex Boten <[email protected]> * update metadata module Signed-off-by: Alex Boten <[email protected]> --------- Signed-off-by: Alex Boten <[email protected]>

@thomas11

Updates to the latest version of google.golang.org/genproto in all submodules in the repository. This is necessary because in a recent change, genproto split out some of its subpackages into independent submodules. (googleapis/go-genproto#1015) As a result of this, some users may see the error: ``` google.golang.org/genproto/googleapis/rpc/status: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/status in multiple modules: google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 (/home/runner/go/pkg/mod/google.golang.org/[email protected]/googleapis/rpc/status) google.golang.org/genproto/googleapis/rpc v0.0.0-20230725213213-b022f6e96895 ``` Because pu/pu is using 20230410155749, which has googleapis/rpc as a subpackage, but another dependency references the independent submodule (20230725213213), so the system doesn't know which module to use for the import path, google.golang.org/genproto/googleapis/rpc/status. This is specifically a problem for ProgramTest-based tests for Pulumi Go programs that do not have a go.mod in the test directory. This issue was encountered by @thomas11 while attempting to upgrade dependencies in pulumi-docker (pulumi/pulumi-docker#700). --- The contents of this commit were generated with the following command: ``` find . -name go.mod -exec dirname '{}' ';' | while read R; do (echo "--- $R" && cd "$R" && go get google.golang.org/genproto@latest && go mod tidy) || break done ``` This failed for tests/integration/go/go-build-target which had an old `go 1.17` directive. This was changed to `go 1.20`.

@thomas11

Updates to the latest version of google.golang.org/genproto in all submodules in the repository. This is necessary because in a recent change, genproto split out some of its subpackages into independent submodules. (googleapis/go-genproto#1015) As a result of this, some users may see the error: ``` google.golang.org/genproto/googleapis/rpc/status: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/status in multiple modules: google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 (/home/runner/go/pkg/mod/google.golang.org/[email protected]/googleapis/rpc/status) google.golang.org/genproto/googleapis/rpc v0.0.0-20230725213213-b022f6e96895 ``` Because pu/pu is using 20230410155749, which has googleapis/rpc as a subpackage, but another dependency references the independent submodule (20230725213213), so the system doesn't know which module to use for the import path, google.golang.org/genproto/googleapis/rpc/status. This is specifically a problem for ProgramTest-based tests for Pulumi Go programs that do not have a go.mod in the test directory. This issue was encountered by @thomas11 while attempting to upgrade dependencies in pulumi-docker (pulumi/pulumi-docker#700). --- The contents of this commit were generated with the following command: ``` find . -name go.mod -exec dirname '{}' ';' | while read R; do (echo "--- $R" && cd "$R" && go get google.golang.org/genproto@latest && go mod tidy) || break done ``` This failed for tests/integration/go/go-build-target which had an old `go 1.17` directive. This was changed to `go 1.20`. This also accidentally tidied up go/regress-13301 which was reverted. A follow-up is incoming to prevent issues like that in the future.

13593: deps: Upgrade google.golang.org/genproto r=abhinav a=abhinav Updates to the latest version of google.golang.org/genproto in all submodules in the repository. This is necessary because in a recent change, genproto split out some of its subpackages into independent submodules. (googleapis/go-genproto#1015) As a result of this, some users may see the error: ``` google.golang.org/genproto/googleapis/rpc/status: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/status in multiple modules: google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 (/home/runner/go/pkg/mod/google.golang.org/[email protected]/googleapis/rpc/status) google.golang.org/genproto/googleapis/rpc v0.0.0-20230725213213-b022f6e96895 ``` Because pu/pu is using 20230410155749, which has googleapis/rpc as a subpackage, but another dependency references the independent submodule (20230725213213), so the system doesn't know which module to use for the import path, google.golang.org/genproto/googleapis/rpc/status. This is specifically a problem for ProgramTest-based tests for Pulumi Go programs that do not have a go.mod in the test directory. This issue was encountered by `@thomas11` while attempting to upgrade dependencies in pulumi-docker (pulumi/pulumi-docker#700). --- The contents of this commit were generated with the following command: ``` find . -name go.mod -exec dirname '{}' ';' | while read R; do (echo "--- $R" && cd "$R" && go get google.golang.org/genproto@latest && go mod tidy) || break done ``` This failed for tests/integration/go/go-build-target which had an old `go 1.17` directive. This was changed to `go 1.20`. This also accidentally tidied up go/regress-13301 which was reverted. PR #13596 aims to prevent mistakes like this in the future. Co-authored-by: Abhinav Gupta <[email protected]>

13593: deps: Upgrade google.golang.org/genproto r=abhinav a=abhinav Updates to the latest version of google.golang.org/genproto in all submodules in the repository. This is necessary because in a recent change, genproto split out some of its subpackages into independent submodules. (googleapis/go-genproto#1015) As a result of this, some users may see the error: ``` google.golang.org/genproto/googleapis/rpc/status: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/status in multiple modules: google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 (/home/runner/go/pkg/mod/google.golang.org/[email protected]/googleapis/rpc/status) google.golang.org/genproto/googleapis/rpc v0.0.0-20230725213213-b022f6e96895 ``` Because pu/pu is using 20230410155749, which has googleapis/rpc as a subpackage, but another dependency references the independent submodule (20230725213213), so the system doesn't know which module to use for the import path, google.golang.org/genproto/googleapis/rpc/status. This is specifically a problem for ProgramTest-based tests for Pulumi Go programs that do not have a go.mod in the test directory. This issue was encountered by `@thomas11` while attempting to upgrade dependencies in pulumi-docker (pulumi/pulumi-docker#700). --- The contents of this commit were generated with the following command: ``` find . -name go.mod -exec dirname '{}' ';' | while read R; do (echo "--- $R" && cd "$R" && go get google.golang.org/genproto@latest && go mod tidy) || break done ``` This failed for tests/integration/go/go-build-target which had an old `go 1.17` directive. This was changed to `go 1.20`. This also accidentally tidied up go/regress-13301 which was reverted. PR #13596 aims to prevent mistakes like this in the future. 13598: Changelog and go.mod updates for v3.76.1 r=pulumi-bot a=pulumi-bot bors merge Co-authored-by: Abhinav Gupta <[email protected]> Co-authored-by: github-actions <[email protected]>

@thomas11

Updates to the latest version of google.golang.org/genproto in all submodules in the repository. This is necessary because in a recent change, genproto split out some of its subpackages into independent submodules. (googleapis/go-genproto#1015) As a result of this, some users may see the error: ``` google.golang.org/genproto/googleapis/rpc/status: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/status in multiple modules: google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 (/home/runner/go/pkg/mod/google.golang.org/[email protected]/googleapis/rpc/status) google.golang.org/genproto/googleapis/rpc v0.0.0-20230725213213-b022f6e96895 ``` Because pu/pu is using 20230410155749, which has googleapis/rpc as a subpackage, but another dependency references the independent submodule (20230725213213), so the system doesn't know which module to use for the import path, google.golang.org/genproto/googleapis/rpc/status. This is specifically a problem for ProgramTest-based tests for Pulumi Go programs that do not have a go.mod in the test directory. This issue was encountered by @thomas11 while attempting to upgrade dependencies in pulumi-docker (pulumi/pulumi-docker#700). --- The contents of this commit were generated with the following command: ``` find . -name go.mod -exec dirname '{}' ';' | while read R; do (echo "--- $R" && cd "$R" && go get google.golang.org/genproto@latest && go mod tidy) || break done ``` This failed for tests/integration/go/go-build-target which had an old `go 1.17` directive. This was changed to `go 1.20`. This also accidentally tidied up go/regress-13301 which was reverted. A follow-up is incoming to prevent issues like that in the future.

See googleapis/go-genproto#1015 Several new submodules were carved out of the large genproto module, This is causing an ambiguous import. The resolution here is to use the newly carved out genproto/googleapis/api submodule. Also run go mod tidy. "go build -v ./..." succeeds now.

13593: deps: Upgrade google.golang.org/genproto r=abhinav a=abhinav Updates to the latest version of google.golang.org/genproto in all submodules in the repository. This is necessary because in a recent change, genproto split out some of its subpackages into independent submodules. (googleapis/go-genproto#1015) As a result of this, some users may see the error: ``` google.golang.org/genproto/googleapis/rpc/status: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/status in multiple modules: google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 (/home/runner/go/pkg/mod/google.golang.org/[email protected]/googleapis/rpc/status) google.golang.org/genproto/googleapis/rpc v0.0.0-20230725213213-b022f6e96895 ``` Because pu/pu is using 20230410155749, which has googleapis/rpc as a subpackage, but another dependency references the independent submodule (20230725213213), so the system doesn't know which module to use for the import path, google.golang.org/genproto/googleapis/rpc/status. This is specifically a problem for ProgramTest-based tests for Pulumi Go programs that do not have a go.mod in the test directory. This issue was encountered by `@thomas11` while attempting to upgrade dependencies in pulumi-docker (pulumi/pulumi-docker#700). --- The contents of this commit were generated with the following command: ``` find . -name go.mod -exec dirname '{}' ';' | while read R; do (echo "--- $R" && cd "$R" && go get google.golang.org/genproto@latest && go mod tidy) || break done ``` This failed for tests/integration/go/go-build-target which had an old `go 1.17` directive. This was changed to `go 1.20`. This also accidentally tidied up go/regress-13301 which was reverted. PR #13596 aims to prevent mistakes like this in the future. 13596: test(regress-13301): Avoid accidental tidying r=abhinav a=abhinav The regression test for #13301 needs an intentionally bad go.mod file. This file was excluded from `make tidy`, allowing it to remain invalid, but this doesn't protect it from bulk commands like the following used in #13593 ```bash find . -name go.mod -exec dirname '{}' ';' | while read R; do (cd "$R" && ... && go mod tidy) done ``` In fact, #13593 accidentally tidied this go.mod file (removing the extraneous dependencies critical to the regression test) and failed in CI. To prevent issues like this, rename the go.mod to go.mod.bad, and rename it back to go.mod in the test environment at test time. This also lets us revert the `make tidy` exclusion support in tidy.sh. Co-authored-by: Abhinav Gupta <[email protected]>

13593: deps: Upgrade google.golang.org/genproto r=abhinav a=abhinav Updates to the latest version of google.golang.org/genproto in all submodules in the repository. This is necessary because in a recent change, genproto split out some of its subpackages into independent submodules. (googleapis/go-genproto#1015) As a result of this, some users may see the error: ``` google.golang.org/genproto/googleapis/rpc/status: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/status in multiple modules: google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 (/home/runner/go/pkg/mod/google.golang.org/[email protected]/googleapis/rpc/status) google.golang.org/genproto/googleapis/rpc v0.0.0-20230725213213-b022f6e96895 ``` Because pu/pu is using 20230410155749, which has googleapis/rpc as a subpackage, but another dependency references the independent submodule (20230725213213), so the system doesn't know which module to use for the import path, google.golang.org/genproto/googleapis/rpc/status. This is specifically a problem for ProgramTest-based tests for Pulumi Go programs that do not have a go.mod in the test directory. This issue was encountered by `@thomas11` while attempting to upgrade dependencies in pulumi-docker (pulumi/pulumi-docker#700). --- The contents of this commit were generated with the following command: ``` find . -name go.mod -exec dirname '{}' ';' | while read R; do (echo "--- $R" && cd "$R" && go get google.golang.org/genproto@latest && go mod tidy) || break done ``` This failed for tests/integration/go/go-build-target which had an old `go 1.17` directive. This was changed to `go 1.20`. This also accidentally tidied up go/regress-13301 which was reverted. PR #13596 aims to prevent mistakes like this in the future. Co-authored-by: Abhinav Gupta <[email protected]>

13593: deps: Upgrade google.golang.org/genproto r=abhinav a=abhinav Updates to the latest version of google.golang.org/genproto in all submodules in the repository. This is necessary because in a recent change, genproto split out some of its subpackages into independent submodules. (googleapis/go-genproto#1015) As a result of this, some users may see the error: ``` google.golang.org/genproto/googleapis/rpc/status: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/status in multiple modules: google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 (/home/runner/go/pkg/mod/google.golang.org/[email protected]/googleapis/rpc/status) google.golang.org/genproto/googleapis/rpc v0.0.0-20230725213213-b022f6e96895 ``` Because pu/pu is using 20230410155749, which has googleapis/rpc as a subpackage, but another dependency references the independent submodule (20230725213213), so the system doesn't know which module to use for the import path, google.golang.org/genproto/googleapis/rpc/status. This is specifically a problem for ProgramTest-based tests for Pulumi Go programs that do not have a go.mod in the test directory. This issue was encountered by `@thomas11` while attempting to upgrade dependencies in pulumi-docker (pulumi/pulumi-docker#700). --- The contents of this commit were generated with the following command: ``` find . -name go.mod -exec dirname '{}' ';' | while read R; do (echo "--- $R" && cd "$R" && go get google.golang.org/genproto@latest && go mod tidy) || break done ``` This failed for tests/integration/go/go-build-target which had an old `go 1.17` directive. This was changed to `go 1.20`. This also accidentally tidied up go/regress-13301 which was reverted. PR #13596 aims to prevent mistakes like this in the future. 13596: test(regress-13301): Avoid accidental tidying r=abhinav a=abhinav The regression test for #13301 needs an intentionally bad go.mod file. This file was excluded from `make tidy`, allowing it to remain invalid, but this doesn't protect it from bulk commands like the following used in #13593 ```bash find . -name go.mod -exec dirname '{}' ';' | while read R; do (cd "$R" && ... && go mod tidy) done ``` In fact, #13593 accidentally tidied this go.mod file (removing the extraneous dependencies critical to the regression test) and failed in CI. To prevent issues like this, rename the go.mod to go.mod.bad, and rename it back to go.mod in the test environment at test time. This also lets us revert the `make tidy` exclusion support in tidy.sh. Co-authored-by: Abhinav Gupta <[email protected]>

13593: deps: Upgrade google.golang.org/genproto r=abhinav a=abhinav Updates to the latest version of google.golang.org/genproto in all submodules in the repository. This is necessary because in a recent change, genproto split out some of its subpackages into independent submodules. (googleapis/go-genproto#1015) As a result of this, some users may see the error: ``` google.golang.org/genproto/googleapis/rpc/status: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/status in multiple modules: google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 (/home/runner/go/pkg/mod/google.golang.org/[email protected]/googleapis/rpc/status) google.golang.org/genproto/googleapis/rpc v0.0.0-20230725213213-b022f6e96895 ``` Because pu/pu is using 20230410155749, which has googleapis/rpc as a subpackage, but another dependency references the independent submodule (20230725213213), so the system doesn't know which module to use for the import path, google.golang.org/genproto/googleapis/rpc/status. This is specifically a problem for ProgramTest-based tests for Pulumi Go programs that do not have a go.mod in the test directory. This issue was encountered by `@thomas11` while attempting to upgrade dependencies in pulumi-docker (pulumi/pulumi-docker#700). --- The contents of this commit were generated with the following command: ``` find . -name go.mod -exec dirname '{}' ';' | while read R; do (echo "--- $R" && cd "$R" && go get google.golang.org/genproto@latest && go mod tidy) || break done ``` This failed for tests/integration/go/go-build-target which had an old `go 1.17` directive. This was changed to `go 1.20`. This also accidentally tidied up go/regress-13301 which was reverted. PR #13596 aims to prevent mistakes like this in the future. Co-authored-by: Abhinav Gupta <[email protected]>

@thomas11

Updates to the latest versions of google.golang.org/genproto and google.golang.org/grpc in all submodules in the repository. This is necessary because in a recent change, genproto split out some of its subpackages into independent submodules. (googleapis/go-genproto#1015) As a result of this, some users may see the error: ``` google.golang.org/genproto/googleapis/rpc/status: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/status in multiple modules: google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 (/home/runner/go/pkg/mod/google.golang.org/[email protected]/googleapis/rpc/status) google.golang.org/genproto/googleapis/rpc v0.0.0-20230725213213-b022f6e96895 ``` Because pu/pu is using 20230410155749, which has googleapis/rpc as a subpackage, but another dependency references the independent submodule (20230725213213), so the system doesn't know which module to use for the import path, google.golang.org/genproto/googleapis/rpc/status. This is a problem for codegen tests and ProgramTest-based tests for Pulumi Go programs that do not have a go.mod in the test directory. This issue was encountered by @thomas11 while attempting to upgrade dependencies in pulumi-docker (pulumi/pulumi-docker#700). The grpc upgrade is necessary because the current version of grpc also pulls the outdated version of genproto.

ldemailly · 2024-09-28T00:48:09Z

Just to point out in case it helps someone, that I had a build suddenly break out of the blue... (way past the deadline) and the fix was fortio/fortiotel@e5572ad

ie

go get google.golang.org/genproto@latest

but not do go mod tidy which removes somehow the

	google.golang.org/genproto v0.0.0-20240924160255-9d4c2d233b61 // indirect

entry

ldemailly · 2024-10-04T18:33:11Z

the above (go mod tidy removing the entry) is a problem because it means every dependabot PR fails... any idea what the correct fix is?

codyoss · 2024-10-04T19:25:18Z

@ldemailly can you give a small reproducer of this problem with a go.mod. Likely the solution is to bump some other out of date dependency.

ldemailly · 2024-10-04T20:58:18Z

@ldemailly can you give a small reproducer of this problem with a go.mod. Likely the solution is to bump some other out of date dependency.

Thanks! yes:

git clone https://github.com/fortio/fortiotel
cd fortiotel
go build . # all good/fine
go mod tidy
git diff
go build .  # error as below and this original ticket

diff is

13:57:13 main fortiotel$ go mod tidy
13:57:18 main fortiotel$ git diff
diff --git a/go.mod b/go.mod
index d54dab6..3be40ca 100644
--- a/go.mod
+++ b/go.mod
@@ -46,7 +46,6 @@ require (
        golang.org/x/net v0.29.0 // indirect
        golang.org/x/sys v0.25.0 // indirect
        golang.org/x/text v0.18.0 // indirect
-       google.golang.org/genproto v0.0.0-20240924160255-9d4c2d233b61 // indirect
        google.golang.org/genproto/googleapis/api v0.0.0-20240903143218-8af14fe29dc1 // indirect
        google.golang.org/genproto/googleapis/rpc v0.0.0-20240903143218-8af14fe29dc1 // indirect
        google.golang.org/grpc v1.67.1 // indirect

error after tidy is

$ go build .
../../../go/pkg/mod/google.golang.org/[email protected]/status/status.go:35:2: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/status in multiple modules:
	google.golang.org/genproto v0.0.0-20230216225411-c8e22ba71e44 (/Users/dl/go/pkg/mod/google.golang.org/[email protected]/googleapis/rpc/status)
	google.golang.org/genproto/googleapis/rpc v0.0.0-20240903143218-8af14fe29dc1 (/Users/dl/go/pkg/mod/google.golang.org/genproto/googleapis/[email protected]/status)
../../../go/pkg/mod/github.com/grpc-ecosystem/grpc-gateway/[email protected]/runtime/handler.go:13:2: ambiguous import: found package google.golang.org/genproto/googleapis/api/httpbody in multiple modules:
	google.golang.org/genproto v0.0.0-20230216225411-c8e22ba71e44 (/Users/dl/go/pkg/mod/google.golang.org/[email protected]/googleapis/api/httpbody)
	google.golang.org/genproto/googleapis/api v0.0.0-20240903143218-8af14fe29dc1 (/Users/dl/go/pkg/mod/google.golang.org/genproto/googleapis/[email protected]/httpbody)
../../../go/pkg/mod/go.opentelemetry.io/otel/exporters/otlp/otlptrace/[email protected]/client.go:12:2: ambiguous import: found package google.golang.org/genproto/googleapis/rpc/errdetails in multiple modules:
	google.golang.org/genproto v0.0.0-20230216225411-c8e22ba71e44 (/Users/dl/go/pkg/mod/google.golang.org/[email protected]/googleapis/rpc/errdetails)
	google.golang.org/genproto/googleapis/rpc v0.0.0-20240903143218-8af14fe29dc1 (/Users/dl/go/pkg/mod/google.golang.org/genproto/googleapis/[email protected]/errdetails)

codyoss · 2024-10-04T21:36:26Z

I have filed envoyproxy/go-control-plane#1014. In the meantime another workaround would be to underscore import genproto in your project so that you can control the version of the dependency and there is no ambiguity.

ldemailly · 2024-10-04T22:01:00Z

turns out... it's the go.work or something related to the simple/ sub directory
(btw trying to _ import didn't work because there is nothing at the top and even trying to read say

	protobuf "google.golang.org/genproto/protobuf/api"

 protobuf.File_google_protobuf_api_proto

also somehow left it in indirect

ldemailly · 2024-10-04T22:14:27Z

So in short, sorry for the noise yet maybe that oddity that a sub project go.mod can cause that issue might help someone else

ldemailly · 2024-10-05T00:06:53Z

well it's actually not fixed... go mod tidy in simple if they all use the same toolchain does remove it... thankfully that one isn't done by dependabot and rots but... something fishy is going on

Fix ambiguous import googleapis/go-genproto#1015

fix googleapis/go-genproto#1015

bmulder-innoseis · 2024-11-01T10:34:12Z

well it's actually not fixed... go mod tidy in simple if they all use the same toolchain does remove it... thankfully that one isn't done by dependabot and rots but... something fishy is going on

@ldemailly I don't understand what you mean and I have the same issue. What did you do to work around it?

ldemailly · 2024-11-01T13:42:41Z

@ldemailly I don't understand what you mean and I have the same issue. What did you do to work around it?

the workaround I have is to have a subdirectory with its own go.mod with the added indirect require - having that allows the real go.mod to work and survive go mod tidy. it's a horrible workaround and I don't understand why/how it works (see fortio/fortiotel repo)

bmulder-innoseis · 2024-11-01T13:45:39Z

the workaround I have is to have a subdirectory with its own go.mod with the added indirect require

Oh dear...
Anyway, thanks I guess

Maybe someone can reopen this in the meantime? Or is there another ticket for this?

quartzmo · 2024-11-08T23:43:14Z

See envoyproxy/go-control-plane#1014.

…f68ea54 See googleapis/go-genproto#1015. Sadly grpc-gateway is incompatible with this version of `genproto`: ``` ERROR: no such package '@@org_golang_google_genproto//googleapis/api/httpbody': BUILD file not found in directory 'googleapis/api/httpbody' of external repository @@org_golang_google_genproto. Add a BUILD file to a directory to mark it as a package. ERROR: /private/var/tmp/_bazel_tbg/b1346cddcc70d57afdaa90f7f09f9b2c/external/com_github_grpc_ecosystem_grpc_gateway/runtime/BUILD.bazel:5:11: no such package '@@org_golang_google_genproto//googleapis/api/httpbody': BUILD file not found in directory 'googleapis/api/httpbody' of external repository @@org_golang_google_genproto. Add a BUILD file to a directory to mark it as a package. and referenced by '@@com_github_grpc_ecosystem_grpc_gateway//runtime:go_default_library' ``` Since we are on the final `grpc-gateway/v1` version already[^1], we'll have to make the leap to v2 to fix this. [^1]: https://github.com/grpc-ecosystem/grpc-gateway/releases/tag/v1.16.0

quartzmo pinned this issue May 26, 2023

quartzmo changed the title ~~google.golang.org/genproto has new submodules: upgrade before 2024-03-01 to avoid ambiguous import errors~~ New submodules: upgrade before 2024-03-01 to avoid ambiguous import errors with google.golang.org/genproto May 26, 2023

liggitt mentioned this issue May 26, 2023

Update google.golang.org/genproto kubernetes/kubernetes#118269

Merged

codyoss added the type: process A process-related concern. May include testing, release, or the like. label May 26, 2023

This was referenced May 26, 2023

Isolate submodules, take 2 #1012

Merged

chore(all): update genproto reference to api/rpc submodule versions with back-reference #1016

Merged

quartzmo mentioned this issue May 26, 2023

deps: google.golang.org/genproto to latest in all modules grpc/grpc-go#6319

Merged

This was referenced May 26, 2023

Bump google.golang.org/genproto google/cel-go#714

Merged

Bump google.golang.org/genproto google/gnostic#393

Merged

This was referenced May 26, 2023

chore(all): update google.golang.org/genproto to submodules googleapis/google-api-go-client#2000

Merged

chore(all): update google.golang.org/genproto to submodules googleapis/gax-go#278

Merged

codeboten mentioned this issue Jun 9, 2023

[chore] updating google.golang.org/genproto open-telemetry/opentelemetry-go-contrib#3968

Merged

codeboten pushed a commit to codeboten/opentelemetry-go-contrib that referenced this issue Jun 9, 2023

[chore] updating google.golang.org/genproto

85a117a

This is to avoid issues caused by googleapis/go-genproto#1015 Signed-off-by: Alex Boten <[email protected]>

codeboten pushed a commit to codeboten/opentelemetry-go-contrib that referenced this issue Jun 12, 2023

[chore] updating google.golang.org/genproto

e97390a

This is to avoid issues caused by googleapis/go-genproto#1015 Signed-off-by: Alex Boten <[email protected]>

This was referenced Jul 24, 2023

ambiguous import coderbeans1/terraform-provider-hitachi#6

Open

Update genproto dependency etcd-io/etcd#16301

Closed

abhinav mentioned this issue Jul 26, 2023

deps: Upgrade google.golang.org/{genproto, grpc} pulumi/pulumi#13593

Merged

jchappelow mentioned this issue Jul 26, 2023

go.mod: use carved out googleapis/apis sub module kwilteam/kwil-db#144

Merged

ldemailly mentioned this issue Oct 4, 2024

Solve the goproto issue by updating simple/ (!) fortio/fortiotel#257

Merged

ldemailly mentioned this issue Oct 5, 2024

Update (but back to go mod tidy breaking ./simple/) fortio/fortiotel#258

Merged

yuhan6665 added a commit to yuhan6665/AndroidLibXrayLite that referenced this issue Oct 6, 2024

Update dependencies

9c0d465

Fix ambiguous import googleapis/go-genproto#1015

yuhan6665 mentioned this issue Oct 6, 2024

Update dependencies 2dust/AndroidLibXrayLite#59

Merged

2dust pushed a commit to 2dust/AndroidLibXrayLite that referenced this issue Oct 7, 2024

Update dependencies (#59)

f873bc8

Fix ambiguous import googleapis/go-genproto#1015

skylenet added a commit to ethpandaops/dora that referenced this issue Oct 16, 2024

fix googleapis/go-genproto#1015

0f181a7

skylenet added a commit to ethpandaops/dora that referenced this issue Oct 16, 2024

Merge pull request #156 from ethpandaops/skylenet/fix-go-mod

a53497d

fix googleapis/go-genproto#1015

gmalouf added a commit to gmalouf/indexer that referenced this issue Oct 29, 2024

Address import collision due to googleapis/go-genproto#1015

03995c5

gmalouf mentioned this issue Oct 29, 2024

Build: Address import collision due to https://github.com/googleapis/go-genp… algorand/indexer#1634

Merged

gmalouf added a commit to algorand/indexer that referenced this issue Oct 29, 2024

Address import collision due to googleapis/go-genproto#1015 (#1634)

e0fc340

github-actions bot mentioned this issue Oct 29, 2024

Regenerate code with the latest specification file (eff5e0fc) algorand/java-algorand-sdk#744

Open

alexplischke mentioned this issue Nov 8, 2024

deps: fix go mod tidy saucelabs/saucectl#974

Merged

quartzmo reopened this Nov 8, 2024

github-actions bot mentioned this issue Nov 14, 2024

Regenerate code with the latest specification file (62f9e0fc) algorand/java-algorand-sdk#745

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New submodules: upgrade before 2024-03-01 to avoid ambiguous import errors with google.golang.org/genproto #1015

New submodules: upgrade before 2024-03-01 to avoid ambiguous import errors with google.golang.org/genproto #1015

quartzmo commented May 26, 2023 •

edited by liggitt

Loading

ldemailly commented Sep 28, 2024 •

edited

Loading

ldemailly commented Oct 4, 2024 •

edited

Loading

codyoss commented Oct 4, 2024

ldemailly commented Oct 4, 2024 •

edited

Loading

codyoss commented Oct 4, 2024

ldemailly commented Oct 4, 2024 •

edited

Loading

ldemailly commented Oct 4, 2024

ldemailly commented Oct 5, 2024

bmulder-innoseis commented Nov 1, 2024

ldemailly commented Nov 1, 2024

bmulder-innoseis commented Nov 1, 2024 •

edited

Loading

quartzmo commented Nov 8, 2024

New submodules: upgrade before 2024-03-01 to avoid ambiguous import errors with google.golang.org/genproto #1015

New submodules: upgrade before 2024-03-01 to avoid ambiguous import errors with google.golang.org/genproto #1015

Comments

quartzmo commented May 26, 2023 • edited by liggitt Loading

TL;DR

Background

New submodules in this repo

Avoiding ambiguous imports for submodules

References

ldemailly commented Sep 28, 2024 • edited Loading

ldemailly commented Oct 4, 2024 • edited Loading

codyoss commented Oct 4, 2024

ldemailly commented Oct 4, 2024 • edited Loading

codyoss commented Oct 4, 2024

ldemailly commented Oct 4, 2024 • edited Loading

ldemailly commented Oct 4, 2024

ldemailly commented Oct 5, 2024

bmulder-innoseis commented Nov 1, 2024

ldemailly commented Nov 1, 2024

bmulder-innoseis commented Nov 1, 2024 • edited Loading

quartzmo commented Nov 8, 2024

quartzmo commented May 26, 2023 •

edited by liggitt

Loading

ldemailly commented Sep 28, 2024 •

edited

Loading

ldemailly commented Oct 4, 2024 •

edited

Loading

ldemailly commented Oct 4, 2024 •

edited

Loading

ldemailly commented Oct 4, 2024 •

edited

Loading

bmulder-innoseis commented Nov 1, 2024 •

edited

Loading