feat: support tidb in data source, sql tool, and execute sql tool#829
feat: support tidb in data source, sql tool, and execute sql tool#829Yuan325 merged 19 commits intogoogleapis:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
CLA was signed now. How can I make the CLA checking bot recheck the status? |
|
@Icemap there's a little button in the check details that says "click here to update CLA check". I've triggered it for this PR and looks like it's green |
|
Thanks @kurtisvg, if you find any issues or have some suggestions during the code review, please let me know. I'll fix it ASAP. |
|
Thanks @Icemap! We've had a lot of interest in the repo over the last two days, which is making us run behind. Please give us a few days and we'll get back to you! |
|
/gcbrun |
Yuan325
left a comment
There was a problem hiding this comment.
Hi @Icemap ! Sorry for the late response. I left some comments on this PR. While you make the changes, I'll also start setting up TiDB vm in our integration test.
Please let me know if you require more clarification on any of the feedbacks! :) Thank you again for contributing!!
any updates on this? really appreciate it |
|
Great, @Yuan325. Thanks for the feedback. I'll apply those suggestions ASAP. |
Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
|
Hi @Yuan325 . I've applied all your suggestions. You are such a great reviewer! Thanks for your collaboration. If I missed something, please feel free to leave more suggestions. Great work! |
|
That's cool! @Yuan325 It's a great move, and I'll add more features to enrich these tools later. |
…tool (#829) This PR supports TiDB in: 1. sources - tidb: As a data source; 2. tools - tidb - tidbsql: As a prepared SQL running tool; 3. tools - tidb - tidbexecutesql: As an arbitrary SQL running tool (for development purposes). And its corresponding docs. --------- Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> Co-authored-by: Yuan Teoh <yuanteoh@google.com> 6eaf36a
🤖 I have created a release *beep* *boop* --- ## [0.11.0](v0.10.0...v0.11.0) (2025-08-04) ### ⚠ BREAKING CHANGES * **tools/bigquery-sql:** Ensure invoke always returns a non-null value ([#1020](#1020)) ([9af55b6](9af55b6)) * **tools/bigquery-execute-sql:** Update the return messages ([#1034](#1034)) ([051e686](051e686)) ### Features * Add DuckDB source and tool ([#879](#879)) ([fd14933](fd14933)) * Add TiDB source and tool ([#829](#829)) ([6eaf36a](6eaf36a)) * Interactive web UI for Toolbox ([#1065](#1065)) ([8749b03](8749b03)) * **tools/looker-query-url:** Add support for `looker-query-url` tool ([#1015](#1015)) ([327ddf0](327ddf0)) * **tools/dataplex-lookup-entry:** Add support for `dataplex-lookup-entry` tool ([#1009](#1009)) ([5fa1660](5fa1660)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.11.0](v0.10.0...v0.11.0) (2025-08-04) ### ⚠ BREAKING CHANGES * **tools/bigquery-sql:** Ensure invoke always returns a non-null value ([#1020](#1020)) ([9af55b6](9af55b6)) * **tools/bigquery-execute-sql:** Update the return messages ([#1034](#1034)) ([051e686](051e686)) ### Features * Add DuckDB source and tool ([#879](#879)) ([fd14933](fd14933)) * Add TiDB source and tool ([#829](#829)) ([6eaf36a](6eaf36a)) * Interactive web UI for Toolbox ([#1065](#1065)) ([8749b03](8749b03)) * **tools/looker-query-url:** Add support for `looker-query-url` tool ([#1015](#1015)) ([327ddf0](327ddf0)) * **tools/dataplex-lookup-entry:** Add support for `dataplex-lookup-entry` tool ([#1009](#1009)) ([5fa1660](5fa1660)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 8d0fa67
🤖 I have created a release *beep* *boop* --- ## [0.11.0](googleapis/genai-toolbox@v0.10.0...v0.11.0) (2025-08-04) ### ⚠ BREAKING CHANGES * **tools/bigquery-sql:** Ensure invoke always returns a non-null value ([googleapis#1020](googleapis#1020)) ([9af55b6](googleapis@9af55b6)) * **tools/bigquery-execute-sql:** Update the return messages ([googleapis#1034](googleapis#1034)) ([051e686](googleapis@051e686)) ### Features * Add DuckDB source and tool ([googleapis#879](googleapis#879)) ([fd14933](googleapis@fd14933)) * Add TiDB source and tool ([googleapis#829](googleapis#829)) ([6eaf36a](googleapis@6eaf36a)) * Interactive web UI for Toolbox ([googleapis#1065](googleapis#1065)) ([8749b03](googleapis@8749b03)) * **tools/looker-query-url:** Add support for `looker-query-url` tool ([googleapis#1015](googleapis#1015)) ([327ddf0](googleapis@327ddf0)) * **tools/dataplex-lookup-entry:** Add support for `dataplex-lookup-entry` tool ([googleapis#1009](googleapis#1009)) ([5fa1660](googleapis@5fa1660)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 8d0fa67
🤖 I have created a release *beep* *boop* --- ## [0.11.0](googleapis/genai-toolbox@v0.10.0...v0.11.0) (2025-08-04) ### ⚠ BREAKING CHANGES * **tools/bigquery-sql:** Ensure invoke always returns a non-null value ([googleapis#1020](googleapis#1020)) ([9af55b6](googleapis@9af55b6)) * **tools/bigquery-execute-sql:** Update the return messages ([googleapis#1034](googleapis#1034)) ([051e686](googleapis@051e686)) ### Features * Add DuckDB source and tool ([googleapis#879](googleapis#879)) ([fd14933](googleapis@fd14933)) * Add TiDB source and tool ([googleapis#829](googleapis#829)) ([6eaf36a](googleapis@6eaf36a)) * Interactive web UI for Toolbox ([googleapis#1065](googleapis#1065)) ([8749b03](googleapis@8749b03)) * **tools/looker-query-url:** Add support for `looker-query-url` tool ([googleapis#1015](googleapis#1015)) ([327ddf0](googleapis@327ddf0)) * **tools/dataplex-lookup-entry:** Add support for `dataplex-lookup-entry` tool ([googleapis#1009](googleapis#1009)) ([5fa1660](googleapis@5fa1660)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 8d0fa67
🤖 I have created a release *beep* *boop* --- ## [0.11.0](googleapis/genai-toolbox@v0.10.0...v0.11.0) (2025-08-04) ### ⚠ BREAKING CHANGES * **tools/bigquery-sql:** Ensure invoke always returns a non-null value ([googleapis#1020](googleapis#1020)) ([9af55b6](googleapis@9af55b6)) * **tools/bigquery-execute-sql:** Update the return messages ([googleapis#1034](googleapis#1034)) ([051e686](googleapis@051e686)) ### Features * Add DuckDB source and tool ([googleapis#879](googleapis#879)) ([fd14933](googleapis@fd14933)) * Add TiDB source and tool ([googleapis#829](googleapis#829)) ([6eaf36a](googleapis@6eaf36a)) * Interactive web UI for Toolbox ([googleapis#1065](googleapis#1065)) ([8749b03](googleapis@8749b03)) * **tools/looker-query-url:** Add support for `looker-query-url` tool ([googleapis#1015](googleapis#1015)) ([327ddf0](googleapis@327ddf0)) * **tools/dataplex-lookup-entry:** Add support for `dataplex-lookup-entry` tool ([googleapis#1009](googleapis#1009)) ([5fa1660](googleapis@5fa1660)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> 8d0fa67
🤖 I have created a release *beep* *boop* --- ## [0.11.0](v0.11.0...v0.11.0) (2025-08-05) ### ⚠ BREAKING CHANGES * **tools/bigquery-sql:** Ensure invoke always returns a non-null value ([#1020](#1020)) ([9af55b6](9af55b6)) * **tools/bigquery-execute-sql:** Update the return messages ([#1034](#1034)) ([051e686](051e686)) ### Features * Add TiDB source and tool ([#829](#829)) ([6eaf36a](6eaf36a)) * Interactive web UI for Toolbox ([#1065](#1065)) ([8749b03](8749b03)) * **prebuiltconfigs/cloud-sql-postgres:** Introduce additional parameter to limit context in list tables ([#1062](#1062)) ([c3a58e1](c3a58e1)) * **tools/looker-query-url:** Add support for `looker-query-url` tool ([#1015](#1015)) ([327ddf0](327ddf0)) * **tools/dataplex-lookup-entry:** Add support for `dataplex-lookup-entry` tool ([#1009](#1009)) ([5fa1660](5fa1660)) ### Bug Fixes * **tools/bigquery,mssql,mysql,postgres,spanner,tidb:** Add query logging to execute-sql tools ([#1069](#1069)) ([0527532]([0527532)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.11.0](v0.11.0...v0.11.0) (2025-08-05) ### ⚠ BREAKING CHANGES * **tools/bigquery-sql:** Ensure invoke always returns a non-null value ([#1020](#1020)) ([9af55b6](9af55b6)) * **tools/bigquery-execute-sql:** Update the return messages ([#1034](#1034)) ([051e686](051e686)) ### Features * Add TiDB source and tool ([#829](#829)) ([6eaf36a](6eaf36a)) * Interactive web UI for Toolbox ([#1065](#1065)) ([8749b03](8749b03)) * **prebuiltconfigs/cloud-sql-postgres:** Introduce additional parameter to limit context in list tables ([#1062](#1062)) ([c3a58e1](c3a58e1)) * **tools/looker-query-url:** Add support for `looker-query-url` tool ([#1015](#1015)) ([327ddf0](327ddf0)) * **tools/dataplex-lookup-entry:** Add support for `dataplex-lookup-entry` tool ([#1009](#1009)) ([5fa1660](5fa1660)) ### Bug Fixes * **tools/bigquery,mssql,mysql,postgres,spanner,tidb:** Add query logging to execute-sql tools ([#1069](#1069)) ([0527532]([0527532)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> a09f628
🤖 I have created a release *beep* *boop* --- ## [0.11.0](googleapis/genai-toolbox@v0.11.0...v0.11.0) (2025-08-05) ### ⚠ BREAKING CHANGES * **tools/bigquery-sql:** Ensure invoke always returns a non-null value ([googleapis#1020](googleapis#1020)) ([9af55b6](googleapis@9af55b6)) * **tools/bigquery-execute-sql:** Update the return messages ([googleapis#1034](googleapis#1034)) ([051e686](googleapis@051e686)) ### Features * Add TiDB source and tool ([googleapis#829](googleapis#829)) ([6eaf36a](googleapis@6eaf36a)) * Interactive web UI for Toolbox ([googleapis#1065](googleapis#1065)) ([8749b03](googleapis@8749b03)) * **prebuiltconfigs/cloud-sql-postgres:** Introduce additional parameter to limit context in list tables ([googleapis#1062](googleapis#1062)) ([c3a58e1](googleapis@c3a58e1)) * **tools/looker-query-url:** Add support for `looker-query-url` tool ([googleapis#1015](googleapis#1015)) ([327ddf0](googleapis@327ddf0)) * **tools/dataplex-lookup-entry:** Add support for `dataplex-lookup-entry` tool ([googleapis#1009](googleapis#1009)) ([5fa1660](googleapis@5fa1660)) ### Bug Fixes * **tools/bigquery,mssql,mysql,postgres,spanner,tidb:** Add query logging to execute-sql tools ([googleapis#1069](googleapis#1069)) ([0527532]([googleapis@0527532)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> a09f628
…ogleapis#829) This PR supports TiDB in: 1. sources - tidb: As a data source; 2. tools - tidb - tidbsql: As a prepared SQL running tool; 3. tools - tidb - tidbexecutesql: As an arbitrary SQL running tool (for development purposes). And its corresponding docs. --------- Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com> Co-authored-by: Yuan Teoh <yuanteoh@google.com>
🤖 I have created a release *beep* *boop* --- ## [0.11.0](googleapis/genai-toolbox@v0.10.0...v0.11.0) (2025-08-04) ### ⚠ BREAKING CHANGES * **tools/bigquery-sql:** Ensure invoke always returns a non-null value ([googleapis#1020](googleapis#1020)) ([9af55b6](googleapis@9af55b6)) * **tools/bigquery-execute-sql:** Update the return messages ([googleapis#1034](googleapis#1034)) ([051e686](googleapis@051e686)) ### Features * Add DuckDB source and tool ([googleapis#879](googleapis#879)) ([fd14933](googleapis@fd14933)) * Add TiDB source and tool ([googleapis#829](googleapis#829)) ([6eaf36a](googleapis@6eaf36a)) * Interactive web UI for Toolbox ([googleapis#1065](googleapis#1065)) ([8749b03](googleapis@8749b03)) * **tools/looker-query-url:** Add support for `looker-query-url` tool ([googleapis#1015](googleapis#1015)) ([327ddf0](googleapis@327ddf0)) * **tools/dataplex-lookup-entry:** Add support for `dataplex-lookup-entry` tool ([googleapis#1009](googleapis#1009)) ([5fa1660](googleapis@5fa1660)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [0.11.0](googleapis/genai-toolbox@v0.11.0...v0.11.0) (2025-08-05) ### ⚠ BREAKING CHANGES * **tools/bigquery-sql:** Ensure invoke always returns a non-null value ([googleapis#1020](googleapis#1020)) ([9af55b6](googleapis@9af55b6)) * **tools/bigquery-execute-sql:** Update the return messages ([googleapis#1034](googleapis#1034)) ([051e686](googleapis@051e686)) ### Features * Add TiDB source and tool ([googleapis#829](googleapis#829)) ([6eaf36a](googleapis@6eaf36a)) * Interactive web UI for Toolbox ([googleapis#1065](googleapis#1065)) ([8749b03](googleapis@8749b03)) * **prebuiltconfigs/cloud-sql-postgres:** Introduce additional parameter to limit context in list tables ([googleapis#1062](googleapis#1062)) ([c3a58e1](googleapis@c3a58e1)) * **tools/looker-query-url:** Add support for `looker-query-url` tool ([googleapis#1015](googleapis#1015)) ([327ddf0](googleapis@327ddf0)) * **tools/dataplex-lookup-entry:** Add support for `dataplex-lookup-entry` tool ([googleapis#1009](googleapis#1009)) ([5fa1660](googleapis@5fa1660)) ### Bug Fixes * **tools/bigquery,mssql,mysql,postgres,spanner,tidb:** Add query logging to execute-sql tools ([googleapis#1069](googleapis#1069)) ([0527532]([googleapis@0527532)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <45984206+Yuan325@users.noreply.github.com>
|
@Icemap Hi! We found that the TiDB's log has been taking a big space from the VM and often hit disk full state. I've tried to add the following config in my However, my Thank you! |
|
Got it. Let me loop in our o11y engineers in this PR. |
|
Here is a solution that you can use to delete the extra data immediately, which is restarting Prometheus with an extra parameter. @Yuan325 https://ask.pingcap.com/t/how-to-adjust-the-data-retention-period-for-monitoring-servers/9439 |
|
@Icemap Got it. Yeah, when I check My prometheus service only start with tiup, how do I restarting just that with the extra parameter ( |
This PR supports TiDB in:
And its corresponding docs.