fix: convert RepeatedField metadata into array #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bshaffer
approved these changes
Jan 25, 2022
alicejli
pushed a commit
to alicejli/gax-php
that referenced
this pull request
Feb 4, 2022
alicejli
pushed a commit
to alicejli/gax-php
that referenced
this pull request
Feb 18, 2022
alicejli
added a commit
that referenced
this pull request
Feb 24, 2022
…essage (#354) * feat: testing purposes * updating ApiException * updating REST transport * update RPC status and tests * update for RpcStatus and to return null instead of empty string * refactor methods * fix formatting * changing null coalesce * fix interceptor test * interceptor test * Revert "interceptor test" This reverts commit e735996. * Revert "fix interceptor test" This reverts commit 4ac0c50. * fix: convert RepeatedField metadata into array (#365) * update tests and decodeMetadataErrorInfo fn * update decodeMetadataErrorInfo * update containsErrorInfo * update php docs and tests * refactor * refactor methods * add newline Co-authored-by: Noah Dietz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApiException::createis documented as accepting either anarrayorRepeatedFieldfor$metadata. However, theApiException->metadatais documented as being anarray.ApiException::createwas not converting$metadataof typeRepeatedFieldto anarrayresulting in runtime exceptions when end users attempted to access the$metadataof typeRepeatedFieldwith a key/index.Discovered by #363.
Updates version to 1.11.3 ahead of release.