Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert RepeatedField metadata into array #365

Merged
merged 2 commits into from
Jan 25, 2022

Conversation

noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Jan 25, 2022

ApiException::create is documented as accepting either an array or RepeatedField for $metadata. However, the ApiException->metadata is documented as being an array. ApiException::create was not converting $metadata of type RepeatedField to an array resulting in runtime exceptions when end users attempted to access the $metadata of type RepeatedField with a key/index.

Discovered by #363.

Updates version to 1.11.3 ahead of release.

@noahdietz noahdietz requested review from a team as code owners January 25, 2022 18:42
@bshaffer bshaffer enabled auto-merge (squash) January 25, 2022 18:47
@bshaffer bshaffer merged commit 381f91a into googleapis:main Jan 25, 2022
@noahdietz noahdietz deleted the fix-repeated-field-metadata branch January 25, 2022 19:02
alicejli pushed a commit to alicejli/gax-php that referenced this pull request Feb 4, 2022
alicejli pushed a commit to alicejli/gax-php that referenced this pull request Feb 18, 2022
alicejli added a commit that referenced this pull request Feb 24, 2022
…essage (#354)

* feat: testing purposes

* updating ApiException

* updating REST transport

* update RPC status and tests

* update for RpcStatus and to return null instead of empty string

* refactor methods

* fix formatting

* changing null coalesce

* fix interceptor test

* interceptor test

* Revert "interceptor test"

This reverts commit e735996.

* Revert "fix interceptor test"

This reverts commit 4ac0c50.

* fix: convert RepeatedField metadata into array (#365)

* update tests and decodeMetadataErrorInfo fn

* update decodeMetadataErrorInfo

* update containsErrorInfo

* update php docs and tests

* refactor

* refactor methods

* add newline

Co-authored-by: Noah Dietz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants