Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support stdClass in MockServerStreamingCall #359

Merged
merged 3 commits into from
Jan 19, 2022
Merged

fix: support stdClass in MockServerStreamingCall #359

merged 3 commits into from
Jan 19, 2022

Conversation

bshaffer
Copy link
Contributor

Tests in google/cloud are failing with the following error:

1) Google\Cloud\BigQuery\Storage\Tests\Unit\V1\BigQueryReadClientTest::readRowsExceptionTest
Undefined property: stdClass::$metadata

/tmpfs/src/github/google-cloud-php/vendor/google/gax/src/Testing/MockServerStreamingCall.php:93
/tmpfs/src/github/google-cloud-php/vendor/google/gax/src/ServerStream.php:79
/tmpfs/src/github/google-cloud-php/BigQueryStorage/tests/Unit/V1/BigQueryReadClientTest.php:211

This should fix it!

@bshaffer bshaffer requested review from a team as code owners January 19, 2022 17:17
@bshaffer bshaffer merged commit 46ffa1f into main Jan 19, 2022
@bshaffer bshaffer deleted the support-stdclass-in-mockserverstreamingcall branch January 19, 2022 17:44
@bshaffer bshaffer mentioned this pull request Jan 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alicejli alicejli alicejli approved these changes

@shivgautam shivgautam shivgautam approved these changes

@noahdietz noahdietz Awaiting requested review from noahdietz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bshaffer @alicejli @shivgautam