Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: allow for google/common-protos 2.0 #357

Merged
merged 2 commits into from
Jan 14, 2022
Merged

chore: allow for google/common-protos 2.0 #357

merged 2 commits into from
Jan 14, 2022

Conversation

alicejli
Copy link
Contributor

Update to allow for google/common-protos 2.0. We are keeping google/common-protos 1.0 for backwards-compatibility purposes.

@alicejli alicejli marked this pull request as ready for review January 14, 2022 03:36
@alicejli alicejli requested review from a team as code owners January 14, 2022 03:36
bshaffer
bshaffer reviewed Jan 14, 2022
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@bshaffer bshaffer merged commit ed97cbd into googleapis:main Jan 14, 2022
@alicejli alicejli deleted the updateCommonProtosVersion branch January 14, 2022 17:56
alicejli added a commit to alicejli/gax-php that referenced this pull request Jan 18, 2022
@alicejli
chore: allow for google/common-protos 2.0 (googleapis#357)
d51a41b
@bshaffer bshaffer mentioned this pull request Jan 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alicejli @bshaffer