-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update REST transport error details #352
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Nov 29, 2021
bshaffer
reviewed
Nov 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Just two minor tweaks, and also please add some tests for this.
* feat: add REST server streaming support * refactor & fix premature closing/cancelation * refactor to Status * set all fields of MockStatus in MockServerStreamingCall * support streaming request exceptions * check if index 0 exists in exception body * skip newlines that break up items * add more tests for weird streams Co-authored-by: Lucas Michot <[email protected]> Co-authored-by: Brent Shaffer <[email protected]>
bshaffer
reviewed
Dec 1, 2021
bshaffer
approved these changes
Dec 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if invoking a PHP client library via REST transport (e.g.
$newClient = new ServiceClient(['transport' => 'rest']);
), the error details displayed are serialized improperly resulting in gibberish (or close to it) error messages.For instance, the error message currently if invoking a service that a cloud project is not enabled for looks like this:
With this fix, the error message will instead look like this:
This technically could be considered a breaking change, so we may need to bundle this change into a new version. However, the current behavior is clearly buggy so not sure if this needs to be considered a breaking change.