feat(v2): hook transport telemetry into gax.Invoke and record#496
Merged
quartzmo merged 1 commit intogoogleapis:mainfrom Mar 26, 2026
Merged
Conversation
quartzmo
reviewed
Mar 26, 2026
quartzmo
requested changes
Mar 26, 2026
quartzmo
approved these changes
Mar 26, 2026
westarle
added a commit
to googleapis/google-cloud-go
that referenced
this pull request
Apr 2, 2026
This PR has auth code fill in TelemetryTransportData in order to send details from the transport back up to higher layers. See googleapis/gax-go#496. This in turn allows code in those higher layers to report telemetry information for the last request that is only known by the transport layer. ### Changes Made * **Logical Hostname Extraction:** Updated extraction logic to parse logical hostnames and ports directly from `req.URL` (HTTP) and `cc.Target()` (gRPC) prior to invoking the transport layer. * **Implicit Port Fallback:** Added scheme-based port fallbacks (`80` for HTTP, `443` for HTTPS) when handling URLs with implicit ports.
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: hook TransportTelemetryData into gax, remove experimental ResponseStatusCode
details:
Read server and port from TransportTelemetryData.
Removed experimental
SetResponseStatusCodeandResponseStatusCodefromTransportTelemetryData. Clients of this API should use the newgax.ExtractTelemetryErrorInfoto get this information from the error result.