feat(v2): hook metric recording into gax.Invoke#494
Merged
westarle merged 1 commit intogoogleapis:mainfrom Mar 25, 2026
Merged
Conversation
westarle
force-pushed
the
westarle/metrics-invoke-hook-v4
branch
from
7401789 to
fae1234
Compare
quartzmo
requested changes
Mar 25, 2026
| "url.domain": "test.domain", | ||
| "rpc.system.name": "grpc", | ||
| "error.type": "CLIENT_TIMEOUT", | ||
| "rpc.response.status_code": "UNKNOWN", |
Member
There was a problem hiding this comment.
Why doesn't result in DEADLINE_EXCEEDED? Afaik, a Go Context timeout maps to codes.DeadlineExceeded. https://github.com/grpc/grpc-go/blob/v1.79.3/status/status.go#L156
Contributor
Author
There was a problem hiding this comment.
thanks, that was a helpful link!
westarle
force-pushed
the
westarle/metrics-invoke-hook-v4
branch
from
fae1234 to
e27d518
Compare
westarle
force-pushed
the
westarle/metrics-invoke-hook-v4
branch
from
e27d518 to
d146431
Compare
quartzmo
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This connects #487 with Invoke when the METRICS feature is enabled.