Skip to content

refactor(v2): use getter-style methods for ClientMetrics defaults #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
westarle wants to merge 2 commits into from
Closed

refactor(v2): use getter-style methods for ClientMetrics defaults #480

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
654b785
refactor: use getter-style methods for ClientMetrics defaults
westarle Mar 11, 2026
836a6a0
Merge branch 'main' into westarle/metrics-clientmetrics-getters-v4
westarle Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions v2/telemetry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,20 @@ func WithExplicitBucketBoundaries(boundaries []float64) ClientMetricsOption {
return &boundariesOpt{boundaries: boundaries}
}

func (config *clientMetricsOptions) meterProvider() metric.MeterProvider {
if config.provider != nil {
return config.provider
}
return otel.GetMeterProvider()
}

func (config *clientMetricsOptions) bucketBoundaries() []float64 {
if len(config.explicitBucketBoundaries) > 0 {
return config.explicitBucketBoundaries
}
return defaultHistogramBoundaries
}

// NewClientMetrics initializes and returns a new ClientMetrics instance.
// It is intended to be called once per generated client during initialization.
func NewClientMetrics(opts ...ClientMetricsOption) *ClientMetrics {
Expand All @@ -137,10 +151,7 @@ func NewClientMetrics(opts ...ClientMetricsOption) *ClientMetrics {
opt.Resolve(&config)
}

provider := config.provider
if provider == nil {
provider = otel.GetMeterProvider()
}
provider := config.meterProvider()

var meterAttrs []attribute.KeyValue
if val, ok := config.attributes[ClientService]; ok {
Expand All @@ -157,10 +168,7 @@ func NewClientMetrics(opts ...ClientMetricsOption) *ClientMetrics {

meter := provider.Meter(config.attributes[ClientArtifact], meterOpts...)

boundaries := config.explicitBucketBoundaries
if len(boundaries) == 0 {
boundaries = defaultHistogramBoundaries
}
boundaries := config.bucketBoundaries()

duration, _ := meter.Float64Histogram(
metricName,
Expand Down
Loading