feat(v2): pass logger to downstream via context#474
Merged
westarle merged 2 commits intogoogleapis:mainfrom Mar 10, 2026
Merged
feat(v2): pass logger to downstream via context#474westarle merged 2 commits intogoogleapis:mainfrom
westarle merged 2 commits intogoogleapis:mainfrom
Conversation
hongalex
approved these changes
Mar 9, 2026
westarle
force-pushed
the
feat/callctx-withlogger
branch
from
4141a2a to
d5ca3fa
Compare
westarle
changed the title
quartzmo
reviewed
Mar 10, 2026
|
|
||
| // WithLogger injects a slog.Logger into the context. This logger will be | ||
| // extracted by the client library or transport wrappers to emit logs. | ||
| func WithLogger(ctx context.Context, logger *slog.Logger) context.Context { |
Member
There was a problem hiding this comment.
Maybe rename to WithLoggerContext to match WithTelemetryContext?
Closed
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customers set the slog logger with options.WithLogger. This change allows code to pass it further down ultimately into the transport layer to be used to log error information in production.