-
Notifications
You must be signed in to change notification settings - Fork 42
feat(v2): add IsFeatureEnabled #454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| // Copyright 2025, Google Inc. | ||
| // All rights reserved. | ||
| // | ||
| // Redistribution and use in source and binary forms, with or without | ||
| // modification, are permitted provided that the following conditions are | ||
| // met: | ||
| // | ||
| // * Redistributions of source code must retain the above copyright | ||
| // notice, this list of conditions and the following disclaimer. | ||
| // * Redistributions in binary form must reproduce the above | ||
| // copyright notice, this list of conditions and the following disclaimer | ||
| // in the documentation and/or other materials provided with the | ||
| // distribution. | ||
| // * Neither the name of Google Inc. nor the names of its | ||
| // contributors may be used to endorse or promote products derived from | ||
| // this software without specific prior written permission. | ||
| // | ||
| // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
| // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
| // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | ||
| // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | ||
| // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | ||
| // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | ||
| // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | ||
| // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | ||
| // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
| // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
|
|
||
| package gax | ||
|
|
||
| import ( | ||
| "os" | ||
| "strings" | ||
| "sync" | ||
| ) | ||
|
|
||
| var ( | ||
| // featureEnabledOnce caches results for IsFeatureEnabled. | ||
| featureEnabledOnce sync.Once | ||
|
quartzmo marked this conversation as resolved.
|
||
| featureEnabledStore map[string]bool | ||
| ) | ||
|
|
||
| // IsFeatureEnabled checks if an experimental feature is enabled via | ||
| // environment variable. The environment variable must be prefixed with | ||
| // "GOOGLE_SDK_GO_EXPERIMENTAL_". The feature name passed to this | ||
| // function must be the suffix (e.g., "FOO" for "GOOGLE_SDK_GO_EXPERIMENTAL_FOO"). | ||
| // To enable the feature, the environment variable's value must be "true", | ||
| // case-insensitive. The result for each name is cached on the first call. | ||
| func IsFeatureEnabled(name string) bool { | ||
|
quartzmo marked this conversation as resolved.
|
||
| featureEnabledOnce.Do(func() { | ||
| featureEnabledStore = make(map[string]bool) | ||
| for _, env := range os.Environ() { | ||
| if strings.HasPrefix(env, "GOOGLE_SDK_GO_EXPERIMENTAL_") { | ||
| // Parse "KEY=VALUE" | ||
| kv := strings.SplitN(env, "=", 2) | ||
| if len(kv) == 2 && strings.ToLower(kv[1]) == "true" { | ||
| key := strings.TrimPrefix(kv[0], "GOOGLE_SDK_GO_EXPERIMENTAL_") | ||
| featureEnabledStore[key] = true | ||
| } | ||
| } | ||
| } | ||
| }) | ||
| return featureEnabledStore[name] | ||
| } | ||
|
|
||
| // TestOnlyResetIsFeatureEnabled is for testing purposes only. It resets the cached | ||
|
quartzmo marked this conversation as resolved.
|
||
| // feature flags, allowing environment variables to be re-read on the next call to IsFeatureEnabled. | ||
| // This function is not thread-safe; if another goroutine reads a feature after this | ||
| // function is called but before the `featureEnabledOnce` is re-initialized by IsFeatureEnabled, | ||
| // it may see an inconsistent state. | ||
| func TestOnlyResetIsFeatureEnabled() { | ||
| featureEnabledOnce = sync.Once{} | ||
| featureEnabledStore = nil | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,162 @@ | ||
| // Copyright 2025, Google Inc. | ||
| // All rights reserved. | ||
| // | ||
| // Redistribution and use in source and binary forms, with or without | ||
| // modification, are permitted provided that the following conditions are | ||
| // met: | ||
| // | ||
| // * Redistributions of source code must retain the above copyright | ||
| // notice, this list of conditions and the following disclaimer. | ||
| // * Redistributions in binary form must reproduce the above | ||
| // copyright notice, this list of conditions and the following disclaimer | ||
| // in the documentation and/or other materials provided with the | ||
| // distribution. | ||
| // * Neither the name of Google Inc. nor the names of its | ||
| // contributors may be used to endorse or promote products derived from | ||
| // this software without specific prior written permission. | ||
| // | ||
| // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS | ||
| // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT | ||
| // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR | ||
| // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT | ||
| // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | ||
| // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT | ||
| // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, | ||
| // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY | ||
| // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT | ||
| // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | ||
|
|
||
| package gax | ||
|
|
||
| import ( | ||
| "os" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestIsFeatureEnabled(t *testing.T) { | ||
| tests := []struct { | ||
| name string | ||
| envVar string | ||
| envValue string | ||
| expected bool | ||
| expectedCache bool | ||
| }{ | ||
| { | ||
| name: "EnabledFeature", | ||
| envVar: "GOOGLE_SDK_GO_EXPERIMENTAL_TRACING", | ||
| envValue: "true", | ||
| expected: true, | ||
| expectedCache: true, | ||
| }, | ||
| { | ||
| name: "DisabledFeature", | ||
| envVar: "GOOGLE_SDK_GO_EXPERIMENTAL_ANOTHER", | ||
| envValue: "false", | ||
| expected: false, | ||
| expectedCache: false, | ||
| }, | ||
| { | ||
| name: "MissingFeature", | ||
| envVar: "GOOGLE_SDK_GO_EXPERIMENTAL_MISSING", | ||
| envValue: "", | ||
| expected: false, | ||
| expectedCache: false, | ||
| }, | ||
| { | ||
| name: "CaseInsensitiveTrue", | ||
| envVar: "GOOGLE_SDK_GO_EXPERIMENTAL_MIXED_CASE", | ||
| envValue: "True", | ||
| expected: true, | ||
| expectedCache: true, | ||
| }, | ||
| { | ||
| name: "CaseInsensitiveTrue", | ||
| envVar: "GOOGLE_SDK_GO_EXPERIMENTAL_UPPER_CASE", | ||
| envValue: "TRUE", | ||
| expected: true, | ||
| expectedCache: true, | ||
| }, | ||
| { | ||
| name: "OtherValue", | ||
| envVar: "GOOGLE_SDK_GO_EXPERIMENTAL_INVALID", | ||
| envValue: "1", | ||
| expected: false, | ||
| expectedCache: false, | ||
| }, | ||
| } | ||
|
|
||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| // Reset the global state for each test to ensure isolation | ||
| TestOnlyResetIsFeatureEnabled() | ||
|
|
||
| if tt.envValue != "" { | ||
| os.Setenv(tt.envVar, tt.envValue) | ||
| defer os.Unsetenv(tt.envVar) | ||
| } | ||
|
|
||
| if got := IsFeatureEnabled(tt.envVar[len("GOOGLE_SDK_GO_EXPERIMENTAL_"):]); got != tt.expected { | ||
| t.Errorf("IsFeatureEnabled() = %v, want %v", got, tt.expected) | ||
| } | ||
|
|
||
| // Verify caching behavior after the first call | ||
| if tt.expectedCache && featureEnabledStore[tt.envVar[len("GOOGLE_SDK_GO_EXPERIMENTAL_"):]] != true { | ||
| t.Errorf("Feature %s not correctly cached as true", tt.envVar) | ||
| } else if !tt.expectedCache && featureEnabledStore[tt.envVar[len("GOOGLE_SDK_GO_EXPERIMENTAL_"):]] == true { | ||
| t.Errorf("Feature %s incorrectly cached as true", tt.envVar) | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| // Test that subsequent calls to IsFeatureEnabled do not re-read environment variables | ||
| t.Run("CachingPreventsReread", func(t *testing.T) { | ||
| TestOnlyResetIsFeatureEnabled() | ||
|
|
||
| // Set an environment variable for the first call | ||
| os.Setenv("GOOGLE_SDK_GO_EXPERIMENTAL_CACHED_FEATURE", "true") | ||
| defer os.Unsetenv("GOOGLE_SDK_GO_EXPERIMENTAL_CACHED_FEATURE") | ||
|
|
||
| // First call, should read from env and cache | ||
| if !IsFeatureEnabled("CACHED_FEATURE") { | ||
| t.Fatalf("Expected CACHED_FEATURE to be enabled on first call") | ||
| } | ||
|
|
||
| // Unset the environment variable after the first call | ||
| os.Unsetenv("GOOGLE_SDK_GO_EXPERIMENTAL_CACHED_FEATURE") | ||
|
|
||
| // Second call, should use cached value and still be true | ||
| if !IsFeatureEnabled("CACHED_FEATURE") { | ||
| t.Errorf("Expected CACHED_FEATURE to remain enabled due to caching") | ||
| } | ||
| // Check a new feature that was never set, should be false | ||
| if IsFeatureEnabled("NEW_FEATURE_AFTER_CACHE") { | ||
| t.Errorf("Expected NEW_FEATURE_AFTER_CACHE to be false as it was set after init") | ||
| } | ||
| }) | ||
|
|
||
| // Test with multiple environment variables set | ||
| t.Run("MultipleEnvVars", func(t *testing.T) { | ||
| TestOnlyResetIsFeatureEnabled() | ||
|
|
||
| os.Setenv("GOOGLE_SDK_GO_EXPERIMENTAL_FEATURE1", "true") | ||
| os.Setenv("GOOGLE_SDK_GO_EXPERIMENTAL_FEATURE2", "false") | ||
| os.Setenv("GOOGLE_SDK_GO_EXPERIMENTAL_FEATURE3", "true") | ||
| defer os.Unsetenv("GOOGLE_SDK_GO_EXPERIMENTAL_FEATURE1") | ||
| defer os.Unsetenv("GOOGLE_SDK_GO_EXPERIMENTAL_FEATURE2") | ||
| defer os.Unsetenv("GOOGLE_SDK_GO_EXPERIMENTAL_FEATURE3") | ||
|
|
||
| if !IsFeatureEnabled("FEATURE1") { | ||
| t.Errorf("Expected FEATURE1 to be enabled") | ||
| } | ||
| if IsFeatureEnabled("FEATURE2") { | ||
| t.Errorf("Expected FEATURE2 to be disabled") | ||
| } | ||
| if !IsFeatureEnabled("FEATURE3") { | ||
| t.Errorf("Expected FEATURE3 to be enabled") | ||
| } | ||
| if IsFeatureEnabled("NONEXISTENT_FEATURE") { | ||
| t.Errorf("Expected NONEXISTENT_FEATURE to be disabled") | ||
| } | ||
| }) | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.