-
Notifications
You must be signed in to change notification settings - Fork 48
fix: update genproto with new echo #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | rules_proto | http_archive | digest | `244e0b6` -> `e507ccd` | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-showcase).
…is#979) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [google.golang.org/api](https://github.com/googleapis/google-api-go-client) | require | minor | `v0.65.0` -> `v0.66.0` | --- ### Release Notes <details> <summary>googleapis/google-api-go-client</summary> ### [`v0.66.0`](https://github.com/googleapis/google-api-go-client/releases/v0.66.0) [Compare Source](https://github.com/googleapis/google-api-go-client/compare/v0.65.0...v0.66.0) ##### Features - **all:** auto-regenerate discovery clients, refs [#​1408](https://github.com/googleapis/google-api-go-client/issues/1408) [#​1407](https://github.com/googleapis/google-api-go-client/issues/1407) [#​1406](https://github.com/googleapis/google-api-go-client/issues/1406) [#​1405](https://github.com/googleapis/google-api-go-client/issues/1405) [#​1404](https://github.com/googleapis/google-api-go-client/issues/1404) [#​1394](https://github.com/googleapis/google-api-go-client/issues/1394) - **internal/gensupport:** add 408 to default retry ([#​1397](https://github.com/googleapis/google-api-go-client/issues/1397)) ([576ebbf](https://github.com/googleapis/google-api-go-client/commit/576ebbf87c60944a97ffd44a7f51851bff0e2bba)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-showcase).
…apis#978) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com_google_protobuf](https://github.com/protocolbuffers/protobuf) | http_archive | patch | `v3.19.3` -> `v3.19.4` | --- ### Release Notes <details> <summary>protocolbuffers/protobuf</summary> ### [`v3.19.4`](https://github.com/protocolbuffers/protobuf/releases/v3.19.4) [Compare Source](https://github.com/protocolbuffers/protobuf/compare/v3.19.3...v3.19.4) ### Python - Make libprotobuf symbols local on OSX to fix issue [#​9395](https://github.com/protocolbuffers/protobuf/issues/9395) ([#​9435](https://github.com/protocolbuffers/protobuf/issues/9435)) ### Ruby - Fixed a data loss bug that could occur when the number of `optional` fields in a message is an exact multiple of 32. ([#​9440](https://github.com/protocolbuffers/protobuf/issues/9440)). ### PHP - Fixed a data loss bug that could occur when the number of `optional` fields in a message is an exact multiple of 32. ([#​9440](https://github.com/protocolbuffers/protobuf/issues/9440)). </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-showcase).
Collaborator
|
I don't think we need this PR anymore because I merged #962. I forgot to mention that generated code changes are made by that regen job. |
Contributor
Author
|
Whoops thank you @noahdietz ; turns out I hadn't updated my repo since that PR got merged. Will close this out; thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow in #970, the updated
echo.pb.goand related files did not make it in. This updates the Echo proto to take into account additional fields for testing headers.