Skip to content

Conversation

@vchudnov-g
Copy link
Contributor

BREAKING CHANGE: this changes the flattened method signature for the Messaging.SearchBlurbs() RPC to require a parent parameter.

Without this change, the flattened method does not work, as the required field parent is not supplied.

BREAKING CHANGE: this changes the flattened method signature for the Messaging.SearchBlurbs() RPC to require  a `parent` parameter.
@vchudnov-g vchudnov-g requested a review from a team as a code owner November 24, 2021 20:13
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 24, 2021
@vchudnov-g vchudnov-g changed the title fix!: add parent to method signature for Messaging.SearchBlurbs() fix!: add parent to method signature for Messaging.SearchBlurbs() Nov 24, 2021
Copy link

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vchudnov-g vchudnov-g merged commit d952e0b into master Nov 24, 2021
@vchudnov-g vchudnov-g deleted the regapic_messaging_searchblurbs_parent branch November 24, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants