This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Integrate _OperationFuture into Python LRO #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 82.87% (diff: 82.35%)@@ master #891 diff @@
==========================================
Files 334 334
Lines 12979 13001 +22
Methods 0 0
Messages 0 0
Branches 1706 1712 +6
==========================================
+ Hits 10759 10775 +16
- Misses 1784 1789 +5
- Partials 436 437 +1
|
evaogbe
changed the title
landrito
reviewed
Jan 4, 2017
|
@landrito Something like this? >>> from google.cloud.gapic.example.library.v1 import library_service_client
>>> api = library_service_client.LibraryServiceClient()
>>> name = api.book_path('[SHELF_ID]', '[BOOK_ID]')
>>> response = api.get_big_book(name)
>>> response.add_done_callback(do_something_with) |
|
A bit more verbose. This is what the example is for Ruby. For python I'd imagine it to look like. from google.cloud.gapic.example.library.v1 import library_service_client
api = library_service_client.LibraryServiceClient()
name = api.book_path('[SHELF_ID]', '[BOOK_ID]')
operation_future = api.get_big_book(name)
def callback(operation_future):
# Handle response.
result = operation_future.result
operation_future.add_done_callback(callback)
# Handle metadata.
metadata = operation_future.metadataedit: fix error. |
geigerj
suggested changes
Jan 5, 2017
| @@ -233,6 +233,17 @@ public String addImportLocal(String moduleName, String attributeName) { | |||
| return addImport(ImportType.APP, moduleName, attributeName).shortName(); | |||
| } | |||
|
|
|||
| /** Add an import for the proto associated with the given type. */ | |||
| private PythonImport addImportForType(TypeRef type) { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Other than the need for documentation, this looks fine to me. Ernest's more verbose version is slightly erroneous (it should read operation_future.add_done_callback(callback), and should probably use a different variable name for the callback argument itself) but seems fine in principle. I also think explanatory comments on documentation like that is really useful, even if they seem like overkill to us.
Fixes potential NPE if called with a type that is not a MessageType.
|
PTAL |
geigerj
approved these changes
Jan 10, 2017
michaelbausor
pushed a commit
to michaelbausor/toolkit
that referenced
this pull request
Jan 12, 2017
* Integrate _OperationFuture into Python LRO * Add LRO specific usage for method sample * Change addImportForType to addImportForMessage. Fixes potential NPE if called with a type that is not a MessageType.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements LRO for Python.
Depends on googleapis/gax-python#142 to generate functioning code.