Skip to content
This repository was archived by the owner on Jul 13, 2025. It is now read-only.

Conversation

@michaelbausor
Copy link
Contributor

@michaelbausor michaelbausor commented Jul 25, 2017

cc @dwsupplee @jdpedrie

This PR splits the generated GAPIC client into two files:

  • <API>Gapic: the implementation
  • <API>Client: an empty class which extends <API>Gapic and can be used to hold any partial veneer methods

An update to the Vision API is shown in this PR: googleapis/google-cloud-php#600

@codecov-io
Copy link

codecov-io commented Jul 25, 2017

Codecov Report

Merging #1428 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1428      +/-   ##
============================================
+ Coverage     87.16%   87.17%   +0.01%     
- Complexity     4035     4039       +4     
============================================
  Files           386      387       +1     
  Lines         16216    16231      +15     
  Branches       1770     1770              
============================================
+ Hits          14135    14150      +15     
  Misses         1619     1619              
  Partials        462      462
Impacted Files Coverage Δ Complexity Δ
...m/google/api/codegen/transformer/SurfaceNamer.java 77.56% <ø> (ø) 182 <0> (ø) ⬇️
...ansformer/csharp/CSharpGapicClientTransformer.java 98.77% <100%> (ø) 38 <0> (ø) ⬇️
...codegen/viewmodel/DynamicLangXApiSubclassView.java 100% <100%> (ø) 3 <3> (?)
...codegen/transformer/csharp/CSharpSurfaceNamer.java 92.51% <100%> (ø) 72 <1> (ø) ⬇️
...en/transformer/php/PhpGapicSurfaceTransformer.java 98.57% <100%> (+0.09%) 15 <1> (ø) ⬇️
...e/api/codegen/transformer/php/PhpSurfaceNamer.java 87.75% <100%> (+0.25%) 28 <1> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eae505...e74999d. Read the comment docs.

new FileHeaderTransformer(new PhpImportSectionTransformer());

private static final String XAPI_TEMPLATE_FILENAME = "php/main.snip";
private static final String API_TEMPLATE_FILENAME = "php/main.snip";

This comment was marked as spam.

This comment was marked as spam.

* a parse method to extract the individual identifiers contained within names that are
* returned.
* @experimental
* {@inheritdoc}

This comment was marked as spam.

This comment was marked as spam.

}

@Override
public String getApiWrapperClassImplName(InterfaceConfig interfaceConfig) {

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Copy link
Contributor

@shinfan shinfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelbausor michaelbausor merged commit a057f8d into googleapis:master Aug 4, 2017
@michaelbausor michaelbausor deleted the partial-veneer branch August 4, 2017 18:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants