-
Notifications
You must be signed in to change notification settings - Fork 132
Partial veneer for PHP #1428
Partial veneer for PHP #1428
Conversation
ccc5195 to
17213e8
Compare
Codecov Report
@@ Coverage Diff @@
## master #1428 +/- ##
============================================
+ Coverage 87.16% 87.17% +0.01%
- Complexity 4035 4039 +4
============================================
Files 386 387 +1
Lines 16216 16231 +15
Branches 1770 1770
============================================
+ Hits 14135 14150 +15
Misses 1619 1619
Partials 462 462
Continue to review full report at Codecov.
|
| new FileHeaderTransformer(new PhpImportSectionTransformer()); | ||
|
|
||
| private static final String XAPI_TEMPLATE_FILENAME = "php/main.snip"; | ||
| private static final String API_TEMPLATE_FILENAME = "php/main.snip"; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| * a parse method to extract the individual identifiers contained within names that are | ||
| * returned. | ||
| * @experimental | ||
| * {@inheritdoc} |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| } | ||
|
|
||
| @Override | ||
| public String getApiWrapperClassImplName(InterfaceConfig interfaceConfig) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
shinfan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc @dwsupplee @jdpedrie
This PR splits the generated GAPIC client into two files:
<API>Gapic: the implementation<API>Client: an empty class which extends<API>Gapicand can be used to hold any partial veneer methodsAn update to the Vision API is shown in this PR: googleapis/google-cloud-php#600