Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add jsdoc comment for parameters #94

Merged
merged 26 commits into from
Nov 4, 2019
Merged

feat: add jsdoc comment for parameters #94

merged 26 commits into from
Nov 4, 2019

Commits on Oct 31, 2019

  1. logic for printing comments for parameters

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    add257f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/googleapis/gapic-generato… 

    …r-typescript into jdoc_comment
    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Oct 31, 2019
    Configuration menu
    Copy the full SHA
    3a919e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2019

  1. render comment for parameters

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    5e481a1 View commit details
    Browse the repository at this point in the history

  2. align asterisks

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    005ab29 View commit details
    Browse the repository at this point in the history

  3. escape */ to break the comment

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    b2eab01 View commit details
    Browse the repository at this point in the history

  4. actual type

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    4e4be27 View commit details
    Browse the repository at this point in the history

  5. update baseline

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    c599624 View commit details
    Browse the repository at this point in the history

  6. replace all */

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    ac71706 View commit details
    Browse the repository at this point in the history

  7. add unit test for replace all helper function

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    e931857 View commit details
    Browse the repository at this point in the history

  8. render real js type

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    99bc6b3 View commit details
    Browse the repository at this point in the history

  9. update baseline

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    aa20320 View commit details
    Browse the repository at this point in the history

  10. add request object comment

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    26cd469 View commit details
    Browse the repository at this point in the history

  11. add return comment

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    99614c6 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2019

  1. reformat comments

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    c402996 View commit details
    Browse the repository at this point in the history

  2. gts

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    921a97b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into jdoc_comment

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 authored Nov 4, 2019
    Configuration menu
    Copy the full SHA
    7c294be View commit details
    Browse the repository at this point in the history

  4. add return comments for simple method

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    19e4449 View commit details
    Browse the repository at this point in the history

  5. return comment for all methods

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    8d760c3 View commit details
    Browse the repository at this point in the history

  6. update baseline test

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    47aefd2 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' of https://github.com/googleapis/gapic-generato… 

    …r-typescript into jdoc_comment
    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    994073b View commit details
    Browse the repository at this point in the history

  8. Merge branch 'jdoc_comment' of https://github.com/googleapis/gapic-ge… 

    …nerator-typescript into jdoc_comment
    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    2a8b5fc View commit details
    Browse the repository at this point in the history

  9. feedback

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    486d666 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' of https://github.com/googleapis/gapic-generato… 

    …r-typescript into jdoc_comment
    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    1ba6be8 View commit details
    Browse the repository at this point in the history

  11. update baseline

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    db2b8d4 View commit details
    Browse the repository at this point in the history

  12. simplify logic for printing return comments

    @xiaozhenliu-gg5
    xiaozhenliu-gg5 committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    50a9086 View commit details
    Browse the repository at this point in the history

  13. Merge branch 'master' into jdoc_comment

    @alexander-fenster
    alexander-fenster authored Nov 4, 2019
    Configuration menu
    Copy the full SHA
    3f6d750 View commit details
    Browse the repository at this point in the history