feat(deps): template change for new gts dependency
#354
Conversation
googlebot
added
the
cla: yes
| @@ -19,6 +19,7 @@ | |||
| import * as protosTypes from '../protos/protos'; | |||
| import * as assert from 'assert'; | |||
| import { describe, it } from 'mocha'; | |||
| /* eslint-disable @typescript-eslint/no-var-requires */ | |||
There was a problem hiding this comment.
Unrelated, but I would love to have a proper import here (I remember there were some types problems when we tried it).
There was a problem hiding this comment.
yes, Justin also brought this up in the other PR, import module will bring types in. Basically it's about mock methods like client._innerApiCalls.echo, while _innerApiCalls is private in EchoClient do we want to fix them now? Thank you!
There was a problem hiding this comment.
Can you spend an hour (but not more) on that? If we can make innerApiCalls public (I don't see any real harm about doing it) it might become possible to import and mock it properly. If you figure out you need more changes, then let's leave it as is.
A better alternative is to move unit tests to sinon, removing all the custom mocks :) But this will take more time and we're probably not going to do it now.
| @@ -185,6 +185,7 @@ export class BigQueryStorageClient { | |||
| this.bigQueryStorageStub = this._gaxGrpc.createStub( | |||
| this._opts.fallback ? | |||
| (this._protos as protobuf.Root).lookupService('google.cloud.bigquery.storage.v1beta1.BigQueryStorage') : | |||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | |||
There was a problem hiding this comment.
Do we need both eslint-disable and tsline:disable?
There was a problem hiding this comment.
Right! :) we just need eslint-disable, thank you! also removed tslint in base PR, thanks!
There was a problem hiding this comment.
it does not work without the latest version of gts. This PR was intended to make some pure template change before updating gts, but seems this is more and more overlapped with the gts PR, I may close this later on and resolve all related problems in the base PR: #343
| @@ -17,7 +17,7 @@ | |||
| // ** All changes to this file may be overwritten. ** | |||
|
|
|||
| import * as gax from 'google-gax'; | |||
| import {APICallback, Callback, CallOptions, Descriptors, ClientOptions, LROperation, PaginationCallback, PaginationResponse} from 'google-gax'; | |||
There was a problem hiding this comment.
Hmmmm. Maybe it's better to start actually using these types if possible? :) (in the client template, line 551 and nearby)
PaginationCallback, PaginationResponseimport(this._protos as any)const serviceModule = require('../src');class Operationin gapic-testconst expectedResponse = {};in gapic-test