Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make npm run baseline behave properly with symlinks #302

Merged
merged 1 commit into from
Feb 27, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions typescript/tools/update-baselines.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ import * as ncp from 'ncp';
const rmrf = promisify(rimraf);
const readdirp = promisify(readdir);
const fsstat = util.promisify(fs.stat);
const fssymlink = util.promisify(fs.symlink);
const mkdirp = promisify(mkdir);
const execp = promisify(exec);
const ncpp = promisify(ncp);
Expand Down Expand Up @@ -61,9 +62,11 @@ async function copyBaseline(library: string, root: string, directory = '.') {
} else if (stat.isFile()) {
const baseline = getBaselineFilename(library, relativePath);
// In baselines/, update `package.json` instead of `package.json.baseline`
// (package.json.baseline is a symlink to package.json to make renovate bot happy)
if (relativePath.endsWith(`${path.sep}package.json`)) {
const packageJson = baseline.substring(0, baseline.lastIndexOf('.'));
await ncpp(absolutePath, packageJson);
await fssymlink(packageJson, baseline);
} else {
await ncpp(absolutePath, baseline);
}
Expand Down