Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: escape /*/ in method comments #178

Merged
merged 2 commits into from
Dec 17, 2019
Merged

fix: escape /*/ in method comments #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97ade4d
escape /*/ in method comments
xiaozhenliu-gg5 Dec 17, 2019
ab3cdd7
change install library timeout
xiaozhenliu-gg5 Dec 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/typescript_gapic/_util.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ limitations under the License.
{%- macro printCommentsForMethod(method) -%}
{%- set lines = method.comments -%}
{% for line in lines %}
*{{ line | safe}}
*{{ line.replaceAll('*/', '* /') | safe}}
{%- endfor %}
{%- endmacro -%}

Expand Down
2 changes: 1 addition & 1 deletion typescript/test/test_application/test_ts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const TS_TEST_APPLICATION = path.join(
describe('TestApplication', () => {
describe('Test application for ts users', () => {
it('npm install showcase', async function() {
this.timeout(30000);
this.timeout(60000);
// copy protos to generated client library and copy test application to local.
if (!fs.existsSync(path.join(SHOWCASE_LIB, 'protos'))) {
fs.copySync(PROTOS, path.join(SHOWCASE_LIB, 'protos'));
Expand Down