Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not use console in system test #153

Merged
merged 3 commits into from
Nov 20, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions templates/typescript_gapic/system-test/.eslintrc.yml.njk
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,4 @@ limitations under the License.
---
env:
mocha: true
rules:
no-console: off

Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ const {{ api.naming.productName.toKebabCase()}} = require('{{ api.publishName }}
function main() {
{%- for service in api.services %}
const {{ service.name.toCamelCase() -}}Client = new {{ api.naming.productName.toKebabCase() }}.{{ service.name.toPascalCase() + 'Client' }}();
console.log("{{- service.name.toCamelCase() -}}Client was created!");
{%- endfor %}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import {
function main() {
{%- for service in api.services %}
const {{ service.name.toCamelCase() -}}Client = new {{ service.name.toPascalCase() + 'Client' -}}();
console.log("{{- service.name.toCamelCase() -}}Client was created!");
{%- endfor %}
}

Expand Down
2 changes: 1 addition & 1 deletion templates/typescript_gapic/system-test/install.ts.njk
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ limitations under the License.
-#}
{% import "../_license.njk" as license -%}
{{license.license()}}
import {packNTest} from 'pack-n-play';
import { packNTest } from 'pack-n-play';
import { readFileSync } from 'fs';

describe('typescript consumer tests', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---
env:
mocha: true
rules:
no-console: off

Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ const kms = require('kms');

function main() {
const keyManagementServiceClient = new kms.KeyManagementServiceClient();
console.log("keyManagementServiceClient was created!");
}

main();
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {KeyManagementServiceClient} from 'kms';

function main() {
const keyManagementServiceClient = new KeyManagementServiceClient();
console.log("keyManagementServiceClient was created!");
}

main();
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// ** https://github.com/googleapis/gapic-generator-typescript **
// ** All changes to this file may be overwritten. **

import {packNTest} from 'pack-n-play';
import { packNTest } from 'pack-n-play';
import { readFileSync } from 'fs';

describe('typescript consumer tests', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---
env:
mocha: true
rules:
no-console: off

Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ const redis = require('redis');

function main() {
const cloudRedisClient = new redis.CloudRedisClient();
console.log("cloudRedisClient was created!");
}

main();
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {CloudRedisClient} from 'redis';

function main() {
const cloudRedisClient = new CloudRedisClient();
console.log("cloudRedisClient was created!");
}

main();
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// ** https://github.com/googleapis/gapic-generator-typescript **
// ** All changes to this file may be overwritten. **

import {packNTest} from 'pack-n-play';
import { packNTest } from 'pack-n-play';
import { readFileSync } from 'fs';

describe('typescript consumer tests', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---
env:
mocha: true
rules:
no-console: off

Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ const showcase = require('showcase');

function main() {
const echoClient = new showcase.EchoClient();
console.log("echoClient was created!");
}

main();
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {EchoClient} from 'showcase';

function main() {
const echoClient = new EchoClient();
console.log("echoClient was created!");
}

main();
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// ** https://github.com/googleapis/gapic-generator-typescript **
// ** All changes to this file may be overwritten. **

import {packNTest} from 'pack-n-play';
import { packNTest } from 'pack-n-play';
import { readFileSync } from 'fs';

describe('typescript consumer tests', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---
env:
mocha: true
rules:
no-console: off

Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ const texttospeech = require('@google-cloud/text-to-speech');

function main() {
const textToSpeechClient = new texttospeech.TextToSpeechClient();
console.log("textToSpeechClient was created!");
}

main();
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {TextToSpeechClient} from '@google-cloud/text-to-speech';

function main() {
const textToSpeechClient = new TextToSpeechClient();
console.log("textToSpeechClient was created!");
}

main();
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// ** https://github.com/googleapis/gapic-generator-typescript **
// ** All changes to this file may be overwritten. **

import {packNTest} from 'pack-n-play';
import { packNTest } from 'pack-n-play';
import { readFileSync } from 'fs';

describe('typescript consumer tests', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---
env:
mocha: true
rules:
no-console: off

Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ const translation = require('translation');

function main() {
const translationServiceClient = new translation.TranslationServiceClient();
console.log("translationServiceClient was created!");
}

main();
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import {TranslationServiceClient} from 'translation';

function main() {
const translationServiceClient = new TranslationServiceClient();
console.log("translationServiceClient was created!");
}

main();
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
// ** https://github.com/googleapis/gapic-generator-typescript **
// ** All changes to this file may be overwritten. **

import {packNTest} from 'pack-n-play';
import { packNTest } from 'pack-n-play';
import { readFileSync } from 'fs';

describe('typescript consumer tests', () => {
Expand Down