fix: render subresponse_field as string if it is not null (#346)

* add quote to subresponse_field * feedback
googleapis · Mar 20, 2020 · a0e7b40 · a0e7b40
1 parent 7c90095
commit a0e7b40
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/baselines/logging/src/v2/logging_service_v2_client.ts.baseline b/baselines/logging/src/v2/logging_service_v2_client.ts.baseline
@@ -230,7 +230,8 @@ export class LoggingServiceV2Client {
     this._descriptors.batching = {
       WriteLogEntries: new this._gaxModule.BundleDescriptor(
         'entries',
-        ['log_name','resource','labels'],null,
+        ['log_name','resource','labels'],
+        null,
         gax.createByteLengthFunction(
           // tslint:disable-next-line no-any
           protoFilesRoot.lookupType('google.logging.v2.LogEntry') as any

diff --git a/templates/typescript_gapic/src/$version/$service_client.ts.njk b/templates/typescript_gapic/src/$version/$service_client.ts.njk
@@ -234,7 +234,11 @@ export class {{ service.name }}Client {
         '{{ field }}'
 {%- endfor -%}
         ],
-        {{- method.bundleConfig.batchDescriptor.subresponse_field }},
+{%- if method.bundleConfig.batchDescriptor.subresponse_field === 'null' %}
+        null,
+{%- else %}
+        '{{- method.bundleConfig.batchDescriptor.subresponse_field }}',
+{%- endif %}
         gax.createByteLengthFunction(
           // tslint:disable-next-line no-any
           protoFilesRoot.lookupType('{{ method.bundleConfig.repeatedField }}') as any