Skip to content

build: remove showcase integration tests ads #2370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
parthea merged 3 commits into from
Mar 24, 2025
Merged

build: remove showcase integration tests ads #2370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4f345f
build: remove showcase integration tests ads
parthea Mar 23, 2025
6fd2a66
also remove usage in github action
parthea Mar 23, 2025
1a90f66
update sync-repo-settings.yaml
parthea Mar 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/sync-repo-settings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,11 @@ branchProtectionRules:
- 'mypy (3.13)'
- 'showcase (3.7, showcase)'
- 'showcase (3.13, showcase)'
- 'showcase (3.7, showcase_alternative_templates)'
- 'showcase (3.13, showcase_alternative_templates)'
- 'showcase (3.7, showcase_w_rest_async)'
- 'showcase (3.13, showcase_w_rest_async)'
# TODO(dovs): reenable these when the mtls tests have been debugged and fixed
# See #1218 for details
# - 'showcase-mtls (showcase_mtls)'
# - 'showcase-mtls (showcase_mtls_alternative_templates)'
- 'showcase-mypy'
- 'showcase-mypy (_alternative_templates)'
- 'showcase-unit (3.7)'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
matrix:
# TODO(https://github.com/googleapis/gapic-generator-python/issues/2121) Remove `showcase_w_rest_async` target when async rest is GA.
python: ["3.7", "3.13"]
target: [showcase, showcase_alternative_templates, showcase_w_rest_async]
target: [showcase, showcase_w_rest_async]
logging_scope: ["", "google"]

# TODO(https://github.com/googleapis/gapic-generator-python/issues/2303): use `ubuntu-latest` once this bug is fixed.
Expand Down Expand Up @@ -102,7 +102,7 @@ jobs:
if: ${{ false }} # TODO(dovs): reenable when #1218 is fixed
strategy:
matrix:
target: [showcase_mtls, showcase_mtls_alternative_templates]
target: [showcase_mtls]
max-parallel: 1
runs-on: ubuntu-latest
steps:
Expand Down
22 changes: 0 additions & 22 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,28 +461,6 @@ def showcase_mtls(
)


@nox.session(python=ALL_PYTHON)
def showcase_alternative_templates(session):
templates = path.join(path.dirname(__file__), "gapic", "ads-templates")
showcase(
session,
templates=templates,
other_opts=("old-naming",),
env={"GAPIC_PYTHON_ASYNC": "False", "IGNORE_FILE": "test_universe_domain.py"},
)


@nox.session(python=NEWEST_PYTHON)
def showcase_mtls_alternative_templates(session):
templates = path.join(path.dirname(__file__), "gapic", "ads-templates")
showcase_mtls(
session,
templates=templates,
other_opts=("old-naming",),
env={"GAPIC_PYTHON_ASYNC": "False", "IGNORE_FILE": "test_universe_domain.py"},
)


def run_showcase_unit_tests(session, fail_under=100, rest_async_io_enabled=False):
session.install(
"coverage",
Expand Down