feat: add support for long-running operations with rest transport. #1094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
parthea
reviewed
Nov 19, 2021
Contributor
parthea
left a comment
parthea
left a comment
There was a problem hiding this comment.
Added minor observations
gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2
Outdated
Show resolved
Hide resolved
gapic/templates/%namespace/%name_%version/%sub/services/%service/transports/rest.py.j2
Outdated
Show resolved
Hide resolved
…ce/transports/rest.py.j2 Co-authored-by: Anthonios Partheniou <[email protected]>
…ce/transports/rest.py.j2 Co-authored-by: Anthonios Partheniou <[email protected]>
software-dov
approved these changes
Nov 22, 2021
Contributor
|
Looks good, just two minor nits that shouldn't block the merge. Feel free to integrate them or ignore them. |
Contributor
Author
|
I'll take a look. In some cases the only way I could resolve conflicts between black and flake8 was to remove trailing commas, but that was a different repo. I'll try it. |
Contributor
Author
|
I need to make additional changes:
|
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Dec 8, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [0.58.0](https://www.github.com/googleapis/gapic-generator-python/compare/v0.57.0...v0.58.0) (2021-12-07) ### Features * add support for long-running operations with rest transport. ([#1094](https://www.github.com/googleapis/gapic-generator-python/issues/1094)) ([e89fd23](https://www.github.com/googleapis/gapic-generator-python/commit/e89fd23609625c5aa49acd6c6ee67f87fce324fd)) ### Bug Fixes * ensure rest unit tests have complete coverage ([#1098](https://www.github.com/googleapis/gapic-generator-python/issues/1098)) ([0705d9c](https://www.github.com/googleapis/gapic-generator-python/commit/0705d9c5dbbea793867551e64991be37d8339c6b)) * fix resource path args for paths with =** ([#1089](https://www.github.com/googleapis/gapic-generator-python/issues/1089)) ([309cc66](https://www.github.com/googleapis/gapic-generator-python/commit/309cc66e880e07940866864b03c744310ef56762)) * **snippetgen:** don't create duplicate requests for required oneofs ([#1088](https://www.github.com/googleapis/gapic-generator-python/issues/1088)) ([5531795](https://www.github.com/googleapis/gapic-generator-python/commit/55317956397370a91b1a06ecd476e55f58789807)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Jan 18, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for long-running operations in the rest transport. Some noteworthy points:
the python gapic generator now reads the service yaml file for an api, using a new
service_yamlparameter inpy_gapic_librarytargets. The content of this file is loaded into agoogle.api.Serviceproto and is available in the schema as theAPI.service_yaml_configproperty. This can, in the future, support other features that rely on information in this file. Note that the java, golang, php, and nodejs targets already have this parameter.In addition to unit tests, this change has been tested against a live server using the cloud translate api.
Note that this change is dependent upon feat: add operations rest client to support long-running operations. python-api-core#311.