-
Notifications
You must be signed in to change notification settings - Fork 74
tests: add system tests to check error details #1076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
fd9148f
feat: add support for context manager in client.
b677108
chore: remove extra whitespace.
15b2533
chore: adds autogenerated unit tests.
f5dc286
chore: adds stronger warning.
c560997
chore: fixes tests.
983888b
chore: adds auto-generated tests for ads.
3e49e1a
chore: updates golden files.
b00a6a6
chore: refactor.
77d92c7
chore: refactor.
4707af5
feat: adds close() to transport and ctx to async client.
a136e61
feat: adds close method and removes ctx from transport in ads.
3ab1200
chore: adds warning infobox to docstring.
db48daf
chore: updates integration tests.
73f162c
chore: fixes typo.
d169bc2
Merge branch 'master' into master
atulep 2bb6b49
Merge branch 'master' of github.com:googleapis/gapic-generator-python…
a8814de
Merge branch 'googleapis-master'
6edf8b5
Merge branch 'googleapis:master' into master
atulep aa5a9ee
Merge branch 'master' of github.com:googleapis/gapic-generator-python
b7363ca
feat: adds system tests to check error details.
e219710
chore: address pr comments.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| # Copyright 2021 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # https://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| import pytest | ||
| from google import showcase | ||
| from google.rpc import error_details_pb2 | ||
| from google.protobuf import any_pb2 | ||
| from grpc_status import rpc_status | ||
| from google.api_core import exceptions | ||
|
|
||
|
|
||
| def create_status(error_details=None): | ||
| status = rpc_status.status_pb2.Status() | ||
| status.code = 3 | ||
| status.message = ( | ||
| "test" | ||
| ) | ||
| status_detail = any_pb2.Any() | ||
| if error_details: | ||
| status_detail.Pack(error_details) | ||
| status.details.append(status_detail) | ||
| return status | ||
|
|
||
|
|
||
| def test_bad_request_details(echo): | ||
| def create_bad_request_details(): | ||
| bad_request_details = error_details_pb2.BadRequest() | ||
| field_violation = bad_request_details.field_violations.add() | ||
| field_violation.field = "test field" | ||
| field_violation.description = "test description" | ||
| return bad_request_details | ||
| bad_request_details = create_bad_request_details() | ||
| status = create_status(bad_request_details) | ||
|
|
||
| with pytest.raises(exceptions.GoogleAPICallError) as e: | ||
| _ = echo.echo(showcase.EchoRequest( | ||
| error=status, | ||
| )) | ||
| assert e.details == [bad_request_details] | ||
|
|
||
|
|
||
| def test_precondition_failure_details(echo): | ||
| def create_precondition_failure_details(): | ||
| pf_details = error_details_pb2.PreconditionFailure() | ||
| violation = pf_details.violations.add() | ||
| violation.type = "test type" | ||
| violation.subject = "test subject" | ||
| violation.description = "test description" | ||
| return pf_details | ||
|
|
||
| pf_details = create_precondition_failure_details() | ||
| status = create_status(pf_details) | ||
|
|
||
| with pytest.raises(exceptions.GoogleAPICallError) as e: | ||
| _ = echo.echo(showcase.EchoRequest( | ||
| error=status, | ||
| )) | ||
| assert e.details == [pf_details] | ||
|
|
||
|
|
||
| def test_unknown_details(echo): | ||
| status = create_status() | ||
| with pytest.raises(exceptions.GoogleAPICallError) as e: | ||
| _ = echo.echo(showcase.EchoRequest( | ||
| error=status, | ||
| )) | ||
| assert e.details == status.details | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.