feat: add a new feature enablement mechanism#1689
feat: add a new feature enablement mechanism#1689shollyman merged 11 commits intogoogleapis:mainfrom
Conversation
This PR adds a new feature enablement mechanism to the Go GAPIC generator. The intent is to pass behavior enablement via protoc flags, with support for the old explicit allowlists until we can transition the usage.
quartzmo
left a comment
There was a problem hiding this comment.
This is a great improvement. I love the more concise conditionals in the production generation code:
if g.cfg.FeatureEnabled(...) {
The level at which the check is expressed is something I've been struggling with as well. Should we hoist the check function up to the generator or leave it on the config? e.g. |
I went ahead and moved the check function up to the generator, so its even simpler. |
This PR adds a new feature enablement mechanism to the Go GAPIC
generator. The intent is to pass behavior enablement via protoc flags,
with support for the old explicit allowlists until we can transition
feature controls to downstream invocation callsites (e.g. bazel rules, librariangen).
This PR also migrates three existing internal features to use the new
feature mechanism: MTLS support, wrapper type support in list RPCs,
and ordered header generation.