chore(internal/testing/sample): add Service, ServiceConfig, InputType and OutputType#1514
Merged
noahdietz merged 2 commits intogoogleapis:mainfrom May 14, 2024
Merged
chore(internal/testing/sample): add Service, ServiceConfig, InputType and OutputType#1514noahdietz merged 2 commits intogoogleapis:mainfrom
noahdietz merged 2 commits intogoogleapis:mainfrom
Conversation
Refactor internal/snippets/snippets_test.go and internal/gengapic/example_test.go to use the internal/testing/sample package. For googleapis#1512
julieqiu
force-pushed
the
pr2.1
branch
2 times, most recently
from
551b7ec to
e2fc950
Compare
noahdietz
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sample values for Service (*serviceconfig.Service), ServiceConfig (*descriptorpb.ServiceDescriptorProto) and InputType and OutputType (*descriptorpb.DescriptorProto).
Update
TestGenSnippetFilein internal/gengapic/example_test.go to use these values.For #1512