chore(internal/snippets,gengapic): use sample values in tests#1513
Merged
noahdietz merged 1 commit intogoogleapis:mainfrom May 13, 2024
Merged
chore(internal/snippets,gengapic): use sample values in tests#1513noahdietz merged 1 commit intogoogleapis:mainfrom
noahdietz merged 1 commit intogoogleapis:mainfrom
Conversation
julieqiu
force-pushed
the
pr2
branch
3 times, most recently
from
2102386 to
3b350ed
Compare
Refactor TestNewMetadata, TestToMetadataJSON and TestRegionTag in internal/snippets/snippets_test.go to use the internal/testing/sample package. For googleapis#1512
noahdietz
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor TestNewMetadata, TestToMetadataJSON and TestRegionTag in internal/snippets/snippets_test.go to use the internal/testing/sample package.
For #1512