chore(internal/testing/sample): add package#1508
Merged
noahdietz merged 2 commits intogoogleapis:mainfrom May 13, 2024
Merged
Conversation
julieqiu
force-pushed
the
organizeex
branch
6 times, most recently
from
4ff7d68 to
2b4c121
Compare
julieqiu
changed the title
julieqiu
force-pushed
the
organizeex
branch
2 times, most recently
from
ded1237 to
c7ffdb1
Compare
Package sample is added, which provides sample values for use in tests. The intent is to make it easier to reason about the various test cases, by using one example and explaining where various values are defined, using bigquery as an example. As a starting point, TestGenSnippetFile has been refactor to use the constants in internal/testing/sample, instead of hardcoding values in the tests. Other tests will be refactored in follow up PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package sample is added, which provides sample values for use in tests.
The intent is to make it easier to reason about the various test cases,
by using one example and explaining where various values are defined,
using bigquery as an example.
As a starting point, TestGenSnippetFile has been refactor to use the
constants in internal/testing/sample, instead of hardcoding values in
the tests. Other tests will be refactored in follow up PRs.