Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DismissRecommendation example. #9

Merged
merged 2 commits into from
Dec 19, 2018
Merged

Conversation

fiboknacky
Copy link
Member

No description provided.

Copy link

@jimper jimper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comment suggestions, otherwise LGTM

@fiboknacky fiboknacky self-assigned this Dec 18, 2018
class DismissRecommendation
{
const CUSTOMER_ID = 'INSERT_CUSTOMER_ID_HERE';
// Recommendation ID is the last alphanumeric portion of resource name obtained from
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"resource name" -> "the resource name"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Change-Id: Ic2b030a20a2b59fed5655eea1bf8b897f6a249db
Copy link

@jimper jimper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants