-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
* #25 - USER_PERMISSION_DENIED. The loginCustomerId header is not added #26
Conversation
imerenanu
commented
Feb 13, 2019
- handles login-customer-id in GoogleAdsGapicClientTrait, passes it further to FixedHeaderMiddleware;
…s not added - handles login-customer-id in GoogleAdsGapicClientTrait, passes it further to FixedHeaderMiddleware;
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing. One minor request.
]); | ||
$headers = [self::$DEVELOPER_TOKEN_KEY => [$this->developerToken]]; | ||
|
||
if (!is_null($this->loginCustomerId)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a brace around this if clause, per PSR-2 standard?
…not added - add a brace around if clause, per PSR-2 standard
Hi @fiboknacky, PSR-2 respected. |
Thank you. Could you take care of CLA check too? |
Hi @fiboknacky , I have submitted CLA agreement. |
Could you reply to GoogleBot as "I signed it!"? |
I signed it! |
I signed it! |
Hi @imerenanu Is it intentional to close this PR? Knack |
Hi @fiboknacky , No, I did it by mistake. Don't know how it happened :) |
Thanks for confirming. |