Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* #25 - USER_PERMISSION_DENIED. The loginCustomerId header is not added #26

Merged
merged 2 commits into from
Feb 18, 2019

Conversation

imerenanu
Copy link
Contributor

  • handles login-customer-id in GoogleAdsGapicClientTrait, passes it further to FixedHeaderMiddleware;

…s not added

- handles login-customer-id in GoogleAdsGapicClientTrait, passes it further to FixedHeaderMiddleware;
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

Copy link
Member

@fiboknacky fiboknacky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing. One minor request.

]);
$headers = [self::$DEVELOPER_TOKEN_KEY => [$this->developerToken]];

if (!is_null($this->loginCustomerId))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a brace around this if clause, per PSR-2 standard?

…not added

- add a brace around if clause, per PSR-2 standard
@imerenanu
Copy link
Contributor Author

Hi @fiboknacky,

PSR-2 respected.

@fiboknacky
Copy link
Member

Hi @fiboknacky,

PSR-2 respected.

Thank you. Could you take care of CLA check too?

@imerenanu
Copy link
Contributor Author

Hi @fiboknacky ,

I have submitted CLA agreement.
I did it behalf of Employer, don't know when it going to be active.

@fiboknacky
Copy link
Member

Hi @fiboknacky ,

I have submitted CLA agreement.
I did it behalf of Employer, don't know when it going to be active.

Could you reply to GoogleBot as "I signed it!"?

@imerenanu
Copy link
Contributor Author

I signed it!

@imerenanu imerenanu closed this Feb 18, 2019
@imerenanu
Copy link
Contributor Author

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

I signed it!

@fiboknacky
Copy link
Member

Hi @imerenanu

Is it intentional to close this PR?
I see that you've signed CLA already, so it's ready to be merged.

Knack

@imerenanu
Copy link
Contributor Author

Hi @fiboknacky ,

No, I did it by mistake. Don't know how it happened :)

@imerenanu imerenanu reopened this Feb 18, 2019
@fiboknacky
Copy link
Member

Thanks for confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants