-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GenerateKeywordIdeas example #13
Conversation
Change-Id: Ic84b25e49cc41e62f029cced8a4b5ddda849d19a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
foreach ($response->getResults() as $result) { | ||
/** @var GenerateKeywordIdeaResult $result */ | ||
// Note that the competition printed below is enum value. | ||
// For example, a value of 2 will be returned when the competition is 'LOW'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanet, could you pls file a bug against the code generator component to make the rendering of this value better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been in my radar.
The proto lib will release a util that helps this soon already. It should be launched soon next year.
use Google\ApiCore\ApiException; | ||
use Google\Protobuf\StringValue; | ||
|
||
/** This example generates keyword ideas from a list of seed keywords. */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or a seed page URL.
Change-Id: Ifd2f8cd5f47d504394b54798bf818f78511d1d32
); | ||
} | ||
|
||
// Specify the optional arguments of the request as a keywordSeed, UrlSeed, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Capitalize 'k' in 'keywordSeed' for consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rather change the other places in this line to lower case to be consistent with the similar sentences in the other line and with the code.
Change-Id: Iebc8d0de3a864df92cfee80f4d43d3e4a9d48792
No description provided.