-
Notifications
You must be signed in to change notification settings - Fork 137
Transparent generic structs #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
joshlf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!! Would you mind rebasing on main now that #119 has merged so that the diff doesn't include those changes as well?
0cd1ea0 to
90678f8
Compare
joshlf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more tiny nit, but otherwise lgtm!
90678f8 to
469c916
Compare
dbcb304 to
ff9ca67
Compare
|
I wanted to incorporate some additional |
Yeah, I miss gerrit all the time 😞 GitHub's UI is great, but the fact that you can't stack PRs is a travesty. I haven't been doing dev on GH long enough to know the real tricks, but so far my approach has been to just carve off one commit at a time to put through the PR cycle. It's a lot easier for me since I'm self-approving a lot of the more minor changes. I feel like where stacked PRs is a huge deal is when you want to have multiple reviews ongoing at a time. |
|
Oh but to respond to your comment about this PR: I saw, and those changes look great! I'm happy to just keep them in this PR and we can figure out a better workflow later if it keeps being a problem. |
eb307a5 to
30acdfe
Compare
Also consolidates some utility types and macros.
|
Got some friction with CI, #69 would help improve the contribution experience. |
Also consolidate some utility types and macros. Closes #9
Fixes #9. Depends on #119 because the generated generic bounds cannot be used in a constant context.