tests: disable apidiff check (#316)

google · Aug 31, 2021 · 3b6fb78 · 3b6fb78
1 parent 7e8af29
commit 3b6fb78
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/internal/check_api_change.sh b/internal/check_api_change.sh
@@ -21,11 +21,11 @@
 # This script expects:
 # a) to be run at the root of the repository
 # b) HEAD is pointing to a commit that merges between the pull request and the
-#    upstream branch (GITHUB_HEAD_REF).
+#    upstream branch (GITHUB_BASE_REF).
 
 set -euo pipefail
 
-UPSTREAM_BRANCH="${GITHUB_HEAD_REF:-master}"
+UPSTREAM_BRANCH="${GITHUB_BASE_REF:-master}"
 echo "Checking for incompatible API changes relative to ${UPSTREAM_BRANCH}..."
 
 MASTER_CLONE_DIR="$(mktemp -d)"

diff --git a/internal/runtests.sh b/internal/runtests.sh
@@ -71,9 +71,10 @@ echo "Ensuring that there are no dependencies not listed in ./internal/alldeps..
 
 # For pull requests, check if there are undeclared incompatible API changes.
 # Skip this if we're already going to fail since it is expensive.
-if ${result} -eq 0 ]] && [[ ! -z "${GITHUB_HEAD_REF:-x}" ]]; then
-  echo
-  ./internal/check_api_change.sh || result=1;
-fi
+# CURRENTLY BROKEN
+# if [[ ${result} -eq 0 ]] && [[ ! -z "${GITHUB_HEAD_REF:-x}" ]]; then
+  # echo
+  # ./internal/check_api_change.sh || result=1;
+# fi
 
 exit $result