Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm scripts for start, build, lint, etc. - fixes #903 #933

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jgautsch
Copy link

@jgautsch jgautsch commented May 5, 2017

Fixes #903

I ran into this issue- where $ gulp serve or even $ gulp -v would fail. The root cause seemed to be that the gulp executable in my path was not the same version as the one in node_modules/.bin/gulp.

npm scripts have the convenient feature of looking in node_modules/.bin for executables, so using npm scripts to run gulp tasks obviates the need to have the correct gulp version globally installed.

With this change, starting is as simple as:

$ npm install
$ npm start

or with yarn:

$ yarn
$ yarn start

This is convenient, conventional, and similar to how other projects like create-react-app.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jgautsch
Copy link
Author

jgautsch commented May 5, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants