Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move apple-touch-icon-precomposed.png into images/touch #411

Merged
merged 1 commit into from
Oct 5, 2014

Conversation

sindresorhus
Copy link
Contributor

as the other touch icons are there.

Reviewer: @addyosmani

Tested on iOS 8, 7, 6.

screen shot 2014-08-29 at 14 00 40
screen shot 2014-08-29 at 13 52 54
screen shot 2014-08-29 at 13 52 18

as the other touch icons are there.
@sindresorhus sindresorhus changed the title move apple-touch-icon-precomposed into images/touch move apple-touch-icon-precomposed.png into images/touch Aug 29, 2014
@addyosmani
Copy link
Contributor

Thanks for testing this out @sindresorhus (and the PR!). We'll aim to verify and get this landed before the next release if all goes well during device testing.

@sindresorhus
Copy link
Contributor Author

@addyosmani ping :)

@addyosmani
Copy link
Contributor

@sindresorhus Haven't forgot about this :) Are you okay with us waiting on the outcome of #442 before we move ahead? I'd like to know if our direction is going to be opting for a single high-res source of truth with generated icons or static icons out of the box.

@sindresorhus
Copy link
Contributor Author

No, this is just a minor change that's fully tested on all the relevant iOS platforms. I don't see why it should be blocked by that most likely long running PR. Either merge or close. I'm fine with either :)

@addyosmani
Copy link
Contributor

Sorry for the delay on getting this tested. Manually verified it works as expected on target iOS devices. LGTM for a merge :)

addyosmani added a commit that referenced this pull request Oct 5, 2014
move apple-touch-icon-precomposed.png into `images/touch`
@addyosmani addyosmani merged commit 12dcb87 into master Oct 5, 2014
@addyosmani addyosmani deleted the move-ios-touch-icon branch October 5, 2014 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants