Skip to content

Commit

Permalink
move apple-touch-icon-precomposed into images/touch
Browse files Browse the repository at this point in the history
  • Loading branch information
@sindresorhus
sindresorhus committed Aug 28, 2014
1 parent b3f1f93 commit a30ddc4
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion app/basic.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<meta name="apple-mobile-web-app-capable" content="yes">
<meta name="apple-mobile-web-app-status-bar-style" content="black">
<meta name="apple-mobile-web-app-title" content="Web Starter Kit">
<link rel="apple-touch-icon-precomposed" href="apple-touch-icon-precomposed.png">
<link rel="apple-touch-icon-precomposed" href="images/touch/apple-touch-icon-precomposed.png">

<!-- Tile icon for Win8 (144x144 + tile color) -->
<meta name="msapplication-TileImage" content="images/touch/ms-touch-icon-144x144-precomposed.png">
Expand Down
0 app/apple-touch-icon-precomposed.png → ...es/touch/apple-touch-icon-precomposed.png
View file
File renamed without changes
2 changes: 1 addition & 1 deletion app/index.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<meta name="apple-mobile-web-app-capable" content="yes">
<meta name="apple-mobile-web-app-status-bar-style" content="black">
<meta name="apple-mobile-web-app-title" content="Web Starter Kit">
<link rel="apple-touch-icon-precomposed" href="apple-touch-icon-precomposed.png">
<link rel="apple-touch-icon-precomposed" href="images/touch/apple-touch-icon-precomposed.png">

<!-- Tile icon for Win8 (144x144 + tile color) -->
<meta name="msapplication-TileImage" content="images/touch/ms-touch-icon-144x144-precomposed.png">
Expand Down

3 comments on commit a30ddc4

@addyosmani
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this change made? It was in root for a reason. Apple guidelines recommend it being there.

Was the moved version tested on iOS devices before we merged it? :)

@addyosmani
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rolled back this change in 266ee06 - sorry >_<

in theory, this change LG but given the amount of time we put into touch icon testing for the last release we should do icon moves in PRs so we can help you verify it's not an issue on iOS6, 7 and 8. You okay with that?

@sindresorhus
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this change made?

The other icons are there.

It was in root for a reason. Apple guidelines recommend it being there.

Where do they recommend that? All I know is that you can put it in root and not need to define it in the HTML, but we already define it in the HTML so it can live anywhere we specify.

Was the moved version tested on iOS devices before we merged it?

It was tested on the iOS 7 simulator and worked fine. I don't see why it should be different with older iOS versions as this tag is ancient.

Please sign in to comment.