Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PPOLoss #396

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Fix PPOLoss #396

merged 1 commit into from
Mar 26, 2020

Conversation

pkol
Copy link
Contributor

@pkol pkol commented Mar 25, 2020

Clipped expression should be multiplied by loss.

Now ppo-loss looks more like in original PPO paper (https://arxiv.org/pdf/1707.06347.pdf)

Clipped expression should be multiplied by loss.
@afrozenator
Copy link
Contributor

Whoa! Many thanks!

@afrozenator afrozenator added the ready to pull Added when the PR is ready to be merged. label Mar 25, 2020
@trax-robot trax-robot merged commit e2c6509 into google:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull Added when the PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants