Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update intro.ipynb #335

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Update intro.ipynb #335

merged 1 commit into from
Mar 19, 2020

Conversation

friesel
Copy link
Contributor

@friesel friesel commented Feb 27, 2020

The mask in trax_intro.ipynb currently includes the last input-token.

It should, however, start with the first output token.

@afrozenator
Copy link
Contributor

Thanks @friesel for fixing this!

@afrozenator afrozenator added the ready to pull Added when the PR is ready to be merged. label Mar 19, 2020
@trax-robot trax-robot merged commit eb28db1 into google:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull Added when the PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants