Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RL: let it work outside of google #312

Merged
merged 1 commit into from
Apr 17, 2020
Merged

Conversation

pkol
Copy link
Contributor

@pkol pkol commented Feb 21, 2020

  • removed unused module import - this module was marked as google internal
  • updated usage info

Copy link
Contributor

@afrozenator afrozenator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi pkol@ - Thanks for the PR! I will handle the atari_utils internally, since we need those, for now feel free to delete them in your fork, and lets only do the rl_trainer.py change s/acrobot/ppo_acrobot

@pkol
Copy link
Contributor Author

pkol commented Mar 19, 2020

Hi @afrozenator - I've updated it according to your suggestions, so now it's only update to comment.

@afrozenator afrozenator added the ready to pull Added when the PR is ready to be merged. label Mar 19, 2020
@afrozenator
Copy link
Contributor

Thanks @pkol -- will merge in shortly!

--train_batch_size=${TRAIN_BATCH_SIZE} \
--output_dir=${HOME}/ppo_acrobot \
--vmodule=*/trax/*=1 \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does vmodule not work externally?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afrozenator it does not:
FATAL Flags parsing error: Unknown command line flag 'vmodule'. Did you mean: model ?

BTW what it was supposed to do?

@trax-robot trax-robot merged commit fa2fa9f into google:master Apr 17, 2020
@afrozenator
Copy link
Contributor

afrozenator commented Apr 21, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull Added when the PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants