-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RL: let it work outside of google #312
Conversation
pkol
commented
Feb 21, 2020
- removed unused module import - this module was marked as google internal
- updated usage info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi pkol@ - Thanks for the PR! I will handle the atari_utils internally, since we need those, for now feel free to delete them in your fork, and lets only do the rl_trainer.py change s/acrobot/ppo_acrobot
Hi @afrozenator - I've updated it according to your suggestions, so now it's only update to comment. |
Thanks @pkol -- will merge in shortly! |
--train_batch_size=${TRAIN_BATCH_SIZE} \ | ||
--output_dir=${HOME}/ppo_acrobot \ | ||
--vmodule=*/trax/*=1 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does vmodule not work externally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@afrozenator it does not:
FATAL Flags parsing error: Unknown command line flag 'vmodule'. Did you mean: model ?
BTW what it was supposed to do?
Yes, no worries, I figured it out, for some reason absl-py/flags doesn't
have it.
It sets the verbosity of the logging per module, in the above example it
sets verbosity of trax to 1.
…On Tue, Apr 21, 2020 at 5:57 AM Paweł Kołodziej ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In trax/rl_trainer.py
<#312 (comment)>:
> --train_batch_size=${TRAIN_BATCH_SIZE} \
--output_dir=${HOME}/ppo_acrobot \
- --vmodule=*/trax/*=1 \
@afrozenator <https://github.com/afrozenator> it does not:
FATAL Flags parsing error: Unknown command line flag 'vmodule'. Did you
mean: model ?
BTW what it was supposed to do?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#312 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIUEFT7F2QOQZF6C4EJCZTRNWJ25ANCNFSM4KZCM3AA>
.
--
We are here on earth to do good for others. What the others are here for, I
don't know.
Afroz Mohiuddin
|