Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change documentation language to ease readability #256

Merged
merged 2 commits into from
Apr 18, 2020

Conversation

stephenjfox
Copy link
Contributor

@stephenjfox stephenjfox commented Jan 24, 2020

Summary

These are changes to the top-level README

  • Ordered list for "see how to use Trax as a library"
  • Small tweaks to grammar around gin-config recommendation.
  • Rephrase Structure.layers bullet point and use the past tense "built"

Intent

As the commit message states, I wanted to make it easier to read this top-level guide to such a valuable resource for entering the Deep Learning Research community.

I mostly touched on things that I had to re-read on first visit. Of course, I mean no offense if the current language is the preference.

* Small tweaks to grammar around gin-config recommendation.
* Rephrase Structure.layers bullet point and use the past tense "built"
* Ordered list for "see how to use Trax as a library"
3. train it and run inference.

With Colab, you can select a CPU or GPU runtime, or even get a free 8-core TPU as
runtime. Please not, with TPUs in colab you need to set extra flags as demonstrated in these
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/not/note

@afrozenator afrozenator added the ready to pull Added when the PR is ready to be merged. label Apr 17, 2020
@trax-robot trax-robot merged commit d1d93ef into google:master Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull Added when the PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants