Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropout: require rng only while training. #134

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

pkol
Copy link
Contributor

@pkol pkol commented Nov 22, 2019

Dropout's forward_with_state() does not use rng in evel&predict mode so it may not require it. It makes inference a little simpler.

@afrozenator afrozenator added the ready to pull Added when the PR is ready to be merged. label Nov 22, 2019
@afrozenator
Copy link
Contributor

Hi @pkol - Can you resolve the conflicts? Thanks!

@afrozenator afrozenator removed the ready to pull Added when the PR is ready to be merged. label Dec 10, 2019
@pkol pkol force-pushed the dropout_without_rng branch from f80d49f to 8da8c5a Compare December 10, 2019 18:31
@pkol
Copy link
Contributor Author

pkol commented Dec 10, 2019

@afrozenator sure. done.

@afrozenator afrozenator added the ready to pull Added when the PR is ready to be merged. label Dec 10, 2019
trax-robot pushed a commit that referenced this pull request Dec 10, 2019
@trax-robot trax-robot merged commit 8da8c5a into google:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes ready to pull Added when the PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants