Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup reference from PR#449 #453

Merged

Conversation

tzujenchanmbd
Copy link
Collaborator

Thanks @polettif for catching these inconsistencies!

The changes are totally the same with PR#449. We open this PR due to CLA problem.

@polettif would you like to review if this covers all your suggested changes?

No voting needed.

@tzujenchanmbd tzujenchanmbd added GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule Change: Editorial Inconsequential changes to the specification such as link updates, grammatical errors, formatting. labels May 14, 2024
@polettif
Copy link

@polettif would you like to review if this covers all your suggested changes?

Looks good to me, thank you. The date on top is still Revised Nov 16, 2023, just to let you know.

Copy link
Collaborator

@Sergiodero Sergiodero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well @tzujenchanmbd, as for the Revised Date I had a quick look and the latest significant change to the Reference document was the adoption of Flex, which was merged on March 19th, 2024. Besides that, we've had several clarifications and editorial changes, with the latest of them being merged on May 7th.

@tzujenchanmbd
Copy link
Collaborator Author

Thanks! @polettif @Sergiodero
I will update the date on the top and changes.md in another PR

@tzujenchanmbd tzujenchanmbd merged commit 60af994 into google:master May 16, 2024
2 checks passed
@tzujenchanmbd tzujenchanmbd mentioned this pull request May 16, 2024
@jcpitre
Copy link

jcpitre commented May 22, 2024

@tzujenchanmbd as long as you are modifying the reference page for revision history, there is a super minor point that you might want to correct also.
The Revision History link currently points to https://gtfs.org/schedule/revision-history and for some reason this goes to the top of https://gtfs.org/schedule/process/

You should consider changing the link to https://gtfs.org/schedule/process/#revision-history so it jumps directly to the actual revision history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Change: Editorial Inconsequential changes to the specification such as link updates, grammatical errors, formatting. GTFS Schedule Issues and Pull Requests that focus on GTFS Schedule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants