Implement bulk re-exports for instantiate setter perf #1957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 10, 2015
| @@ -349,12 +349,14 @@ export class InstantiateModuleTransformer extends ModuleTransformer { | |||
|
|
|||
| // then do export bindings of re-exported dependencies | |||
| if (externalExportBindings) { | |||
| let reexports = {}; | |||
There was a problem hiding this comment.
What about __proto__ etc? You probably need to use Object.create(null) or new StringMap().
|
Conceptually this looks good. |
|
Thanks, I've updated the PR. |
guybedford
force-pushed
the
instantiate-bulk-export
branch
from
63434d8
to
7abe36f
Compare
|
LGTM, I'll squash and merge |
|
Committed as 84956a2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aurelia had some issues with bulk exports causing performance bottlenecks due to the repeated bindings being called in quadratic multiples of the depth of
export *usage. This function flattens the binding call in one go. It may be worth always having$__export({ name: 'value' })as an object so we don't need to overload the function, so could look at a PR to do this if you think it is worthwhile, but the named form of$__export(name, 'value')will still be necessary for backwards compatibility for a while regardless.Associated ModuleLoader PR is at ModuleLoader/es-module-loader#387.