Structarray #127
Structarray #127
Conversation
…t this on open mode.
Structarray validation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| virtual Result<size_t> GetComponentIndex(const void* metadata, | ||
| OpenMode open_mode) = 0; | ||
| /// attempt to cast to a Void type ... | ||
| virtual Result<std::shared_ptr<void>> AsByteArray( |
There was a problem hiding this comment.
I think we can make this change purely in the zarr driver, rather than here in kvs_backed_chunk_driver.h
In particular, if the user does not specify a field, then we can always just open as a byte array.
I also think rather than create synthetic metadata it would be better to just create an additional special dtype field for the byte array representation. The synthetic metadata approach has some drawbacks.
3 participants
No description provided.