-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated tokio-proto and replace with homegrown rpc framework #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bench harness doesn't really work with futures.
…lient_addr in the process
This probably shouldn't be merged until rust-lang/rust#53443 is fixed, because otherwise services can't be used outside the crate in which they're defined. |
benbrittain
reviewed
Sep 22, 2018
This was referenced Oct 3, 2018
Closed
tikue
force-pushed
the
rm-error
branch
3 times, most recently
from
October 15, 2018 21:16
36e4846
to
6273337
Compare
This went way more smoothly than I expected! The one thing that I had to workaround was the lack of proc-macro support for parsing paths. In the one usage of that, I worked around it by importing the type I needed to reference in the proc macro.
This was referenced Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Crates
All names are pending.
All crates are now at the top level. e.g. tarpc-plugins is now tarpc/plugins rather than tarpc/src/plugins. tarpc itself is now a very small code surface, as most functionality has been moved into the other more granular crates.
New Features
Removals
Open Questions
Future<Response>
orFuture<Future<Response>>
? The former appears more ergonomic but it doesn’t allow concurrent requests with a single client handle. The latter is less ergonomic but yields back control of the client once it’s successfully sent out the request. Should we offer fns for both?Fixes #178 #155 #124 #104 #83 #38