Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated tokio-proto and replace with homegrown rpc framework #199

Merged
merged 59 commits into from
Oct 16, 2018

Conversation

tikue
Copy link
Collaborator

@tikue tikue commented Aug 31, 2018

New Crates

All names are pending.

  • crate rpc contains the core client/server request-response framework, as well as a transport trait.
  • crate bincode-transport implements a transport that works almost exactly as tarpc works today (not to say it's wire-compatible).
  • crate trace has some foundational types for tracing. This isn't really fleshed out yet, but it's useful for in-process log tracing, at least.

All crates are now at the top level. e.g. tarpc-plugins is now tarpc/plugins rather than tarpc/src/plugins. tarpc itself is now a very small code surface, as most functionality has been moved into the other more granular crates.

New Features

  • deadlines: all requests specify a deadline, and a server will stop processing a response when past its deadline.
  • client cancellation propagation: when a client drops a request, the client sends a message to the server informing it to cancel its response. This means cancellations can propagate across multiple server hops.
  • trace context stuff as mentioned above
  • more server configuration for total connection limits, per-connection request limits, etc.

Removals

  • no more shutdown handle. I left it out for now because of time and not being sure what the right solution is.
  • all async now, no blocking stub or server interface. This helps with maintainability, and async/await makes async code much more usable. The service trait is thusly renamed Service, and the client is renamed Client.
  • no built-in transport. Tarpc is now transport agnostic (see bincode-transport for transitioning existing uses).
  • going along with the previous bullet, no preferred transport means no TLS support at this time. We could make a tls transport or make bincode-transport compatible with TLS.
  • a lot of examples were removed because I couldn't keep up with maintaining all of them. Hopefully the ones I kept are still illustrative.
  • no more plugins!

Open Questions

  1. Should client.send() return Future<Response> or Future<Future<Response>>? The former appears more ergonomic but it doesn’t allow concurrent requests with a single client handle. The latter is less ergonomic but yields back control of the client once it’s successfully sent out the request. Should we offer fns for both?
  2. Should rpc service! Fns take &mut self or &self or self? The service needs to impl Clone anyway, technically we only need to clone it once per connection, and then leave it up to the user to decide if they want to clone it per RPC. In practice, everyone doing nontrivial stuff will need to clone it per RPC, I think.
  3. Do the request/response structs look ok?
  4. Is supporting server shutdown/lameduck important?

Fixes #178 #155 #124 #104 #83 #38

@tikue tikue self-assigned this Aug 31, 2018
@tikue tikue requested a review from shaladdle August 31, 2018 20:40
@tikue
Copy link
Collaborator Author

tikue commented Sep 19, 2018

This probably shouldn't be merged until rust-lang/rust#53443 is fixed, because otherwise services can't be used outside the crate in which they're defined.

@tikue tikue requested a review from benbrittain September 21, 2018 02:16
This was referenced Oct 3, 2018
@tikue tikue force-pushed the rm-error branch 3 times, most recently from 36e4846 to 6273337 Compare October 15, 2018 21:16
tikue added 3 commits October 15, 2018 22:10
This went way more smoothly than I expected! The one thing that I had to workaround was the lack of proc-macro support for parsing  paths. In the one usage of that, I worked around it by importing the type I needed to reference in the proc macro.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants