Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod: tidy and vendor with Go 1.16 #2459

Merged
merged 1 commit into from
Mar 7, 2021
Merged

Conversation

mvdan
Copy link
Contributor

@mvdan mvdan commented Feb 25, 2021

(see commit message)

@mvdan
Copy link
Contributor Author

mvdan commented Feb 25, 2021

Error: Please limit commit description line length to 120 characters.

... but it's an error message, copy-pasted verbatim. I think your CI check is too aggressive perhaps.

@dvyukov
Copy link
Collaborator

dvyukov commented Feb 25, 2021

Error: Please limit commit description line length to 120 characters.

... but it's an error message, copy-pasted verbatim. I think your CI check is too aggressive perhaps.

I agree it is aggressive. But the useful question is if it's better/worse than the alternative of checking everything manually, nitpicking on PRs, forcing lots of revisions and tolerating inconsistencies in the code base in the situation where maintainer does not have time for that, lots of contributors don't have experience with Go and idea of consistent style and disappear after any comment ;)

It's unclear why the module wasn't already tidy and newly vendored, but
since Go 1.16 defaults to -mod=readonly, oss-fuzz was running into
errors such as:

mvdan.cc/[email protected]:
	is marked as explicit in vendor/modules.txt,
	but not explicitly required in go.mod
@codecov
Copy link

codecov bot commented Mar 7, 2021

Codecov Report

Merging #2459 (03eb88d) into master (fcc6d71) will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted Files Coverage Δ
prog/target.go 60.2% <0.0%> (-5.7%) ⬇️
syz-manager/cover.go 28.6% <0.0%> (-2.2%) ⬇️
prog/rotation.go 94.9% <0.0%> (-1.7%) ⬇️
prog/prog.go 75.4% <0.0%> (-1.2%) ⬇️
prog/any.go 83.5% <0.0%> (-1.0%) ⬇️
pkg/mgrconfig/load.go 3.5% <0.0%> (-<0.1%) ⬇️
pkg/cover/cover.go 84.2% <0.0%> (ø)
pkg/report/linux.go 84.7% <0.0%> (ø)
syz-manager/html.go 0.0% <0.0%> (ø)
dashboard/app/admin.go 0.0% <0.0%> (ø)
... and 11 more

@dvyukov dvyukov merged commit 92345f7 into google:master Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants