Fix overflow checking for repeat operation #558
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current overflow check for repeat operation fails to check when a multiplication wraps to a positive number.
On 64 bits build it is hard to get one (as you would need a tuple/string with more than 2^32 element - but it's still possible).
On a 32 bits build however it is quite trivial:
This PR uses
bits.Mul
to make sure that this does not happen.