Skip to content

Conversation

samizdatco
Copy link
Contributor

The ParagraphStyle struct has as turnHintingOff() setter which toggles its fHintingIsOn flag, but this flag is never read when the paragraph is typeset. As a result, hinting is always enabled regardless of the ParagraphStyle’s settings.

This PR adds a check for hinting having been disabled at the ParagraphStyle level and only defers to the Block's hinting setting if it is enabled.

Note: it's not entirely clear to me that this is the proper (or only) location for this flag to be honored, but having the ability to disable hinting at the ParagraphStyle level is an important feature (since direct access to the Font objects used is unavailable when typesetting paragraphs rather than TextBlobs). It's also a feature that the existing API suggests exists, while currently it has no effect.

@skia-codereview-bot
Copy link

This PR (HEAD: 58e8c05) has been imported to Gerrit for code review.

Please visit review.skia.org/1044296 to see it. Please CC yourself to the Gerrit change.

Note:

  • Skia uses only Gerrit for reviews and submitting code (doc).
  • All comments are handled within Gerrit. Any comments on the GitHub PR will be ignored.
  • The PR author can continue to upload commits to the branch used by the PR in order to address feedback from Gerrit.
  • Once the code is ready to be merged, a maintainer will submit the change on Gerrit and skia-codereview-bot will close this PR.
  • Similarly, if a change is abandoned on Gerrit, the corresponding PR will be closed with a note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants